From: Denis Cheng <crquan@gmail.com>
To: Paul Clements <Paul.Clements@steeleye.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
Steven Whitehouse <steve@chygwyn.com>,
Andrew Morton <akpm@linux-foundation.org>,
Denis Cheng <crquan@gmail.com>
Subject: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable
Date: Thu, 19 Jul 2007 17:34:30 +0800 [thread overview]
Message-ID: <11848376711601-git-send-email-crquan@gmail.com> (raw)
Thus the traverse of the loop may delete nodes, use the safe version.
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
drivers/block/nbd.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index c129510..86639c0 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -237,8 +237,7 @@ error_out:
static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
{
- struct request *req;
- struct list_head *tmp;
+ struct request *req, *n;
struct request *xreq;
int err;
@@ -249,8 +248,7 @@ static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
goto out;
spin_lock(&lo->queue_lock);
- list_for_each(tmp, &lo->queue_head) {
- req = list_entry(tmp, struct request, queuelist);
+ list_for_each_entry_safe(req, n, &lo->queue_head, queuelist) {
if (req != xreq)
continue;
list_del_init(&req->queuelist);
--
1.5.2.2
next reply other threads:[~2007-07-19 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 9:34 Denis Cheng [this message]
2007-07-19 9:34 ` [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call Denis Cheng
2007-07-19 17:35 ` Paul Clements
2007-07-20 1:46 ` rae l
2007-07-19 15:12 ` [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable Paul Clements
2007-07-19 15:55 ` rae l
2007-07-19 16:48 ` rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11848376711601-git-send-email-crquan@gmail.com \
--to=crquan@gmail.com \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=steve@chygwyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.