Re: Seeing some 5.0.1 stop expiring mounts

[Ian Kent <raven@themaw.net>]

On Wed, 2007-07-18 at 14:39 -0700, Mike Marion wrote:
> On Wed, Jul 18, 2007 at 02:46:07PM +0800, Ian Kent wrote:
> 
> > Might be worth considering going to 5.0.2, especially since you have a
> > busy site, as a nasty deadlock in the alarm handler has been fixed. 
> 
> Unfortunately, we can't.  I've since found out (through trial and error)
> that the patch:
> > > autofs-5.0.1-map-update-source-only.patch
> 
> is completely broken for us, and it appears to be part of the 5.0.2
> codebase now.

Indeed.

I think I've identified the problem but I'll need to look more closely
at it.

In the meantime it would be great if you could try this patch, in
addition to the patch above, and check if there are any other problems
with it.

The patch is against the current git repo but applies against a fairly
up to date 5.0.1 tree (it looks correct) with a small offset.

Ian

---
diff --git a/daemon/lookup.c b/daemon/lookup.c
index 70b9e02..4f2b318 100644
--- a/daemon/lookup.c
+++ b/daemon/lookup.c
@@ -325,6 +325,7 @@ static int read_file_source_instance(struct autofs_point *ap, struct map_source
 		instance->recurse = map->recurse;
 		instance->depth = map->depth;
 	}
+	instance->stale = map->stale;
 
 	return do_read_map(ap, instance, age);
 }
@@ -346,6 +347,7 @@ static int read_source_instance(struct autofs_point *ap, struct map_source *map,
 		instance->recurse = map->recurse;
 		instance->depth = map->depth;
 	}
+	instance->stale = map->stale;
 
 	return do_read_map(ap, instance, age);
 }