Received: from exsvlrb01.hq.netapp.com ([10.56.8.62]) by exsvl03.hq.netapp.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 22 Jul 2007 02:59:13 -0700 Received: from sacexrs01.hq.netapp.com ([10.99.190.105]) by exsvlrb01.hq.netapp.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 22 Jul 2007 02:59:13 -0700 Received: from smtp1.corp.netapp.com ([10.57.156.124]) by sacexrs01.hq.netapp.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 22 Jul 2007 02:59:12 -0700 Received: from mx1.netapp.com (mx1.dmz.netapp.com [10.254.64.60]) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id l6M9xBYt020931 for ; Sun, 22 Jul 2007 02:59:12 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAALrHokbDXP0ChGdsb2JhbACPWQEBCQoPGA X-IronPort-AV: E=Sophos;i="4.16,568,1175497200"; d="scan'208";a="89214520" X-SBRS: 3.2 Received: from zeniv.linux.org.uk ([195.92.253.2]) by mx1.netapp.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Jul 2007 02:59:11 -0700 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.52 #1 (Red Hat Linux)) id 1ICYDS-0003JE-Pw; Sun, 22 Jul 2007 10:59:06 +0100 Date: Sun, 22 Jul 2007 10:59:06 +0100 From: Al Viro To: Linus Torvalds Cc: Chuck Lever , Trond Myklebust , linux-kernel@vger.kernel.org Subject: [PATCH] fix broken handling of port=... in NFS option parsing Message-ID: <20070722095906.GX21668@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Return-Path: viro@ftp.linux.org.uk X-OriginalArrivalTime: 22 Jul 2007 09:59:12.0704 (UTC) FILETIME=[F49CC400:01C7CC46] X-Evolution-Source: exchange://trond;auth=NTLM@exsvl03.hq.netapp.com/ Content-Transfer-Encoding: 7bit Obviously broken on little-endian; fortunately, the option is not frequently used... Signed-off-by: Al Viro --- diff --git a/fs/nfs/super.c b/fs/nfs/super.c index b34b7a7..b2a851c 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -732,7 +732,7 @@ static int nfs_parse_mount_options(char *raw, return 0; if (option < 0 || option > 65535) return 0; - mnt->nfs_server.address.sin_port = htonl(option); + mnt->nfs_server.address.sin_port = htons(option); break; case Opt_rsize: if (match_int(args, &mnt->rsize))