All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
Date: Mon, 23 Jul 2007 06:55:11 +0800	[thread overview]
Message-ID: <1185144911.6370.1.camel@daplas> (raw)
In-Reply-To: <Pine.LNX.4.64.0707221218130.18493@anakin>

On Sun, 2007-07-22 at 12:20 +0200, Geert Uytterhoeven wrote:
> On Sat, 21 Jul 2007, Antonino A. Daplas wrote:
> > On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote:
> > > Fix following section mismatch warning:
> > > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to .init.text:__alloc_bootmem (between 'vgacon_startup' and 'vgacon_scrolldelta')
> > > 
> > > Browsing the code it seems that vgacon_scrollback_startup() is only
> > > called during the init phase so the reference to the .init.text
> > > section is OK.
> > > Teach modpost not to warn using ___init_refok.
> > > 
> > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Acked-by: Antonino Daplas <adaplas@gmail.com>
> 
> I assume the check for `vga_init_done' in vgacon_startup() is sufficient to
> prevent vgacon_scrollback_startup() from being called later due to
> (un)bind_con_driver()?
> 

Yes.

Tony



      reply	other threads:[~2007-07-22 22:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 21:27 [PATCH 2/7] console: fix section mismatch warning in vgacon.c Sam Ravnborg
2007-07-20 23:37 ` Antonino A. Daplas
2007-07-21  5:43   ` Sam Ravnborg
2007-07-21  6:01     ` Andrew Morton
2007-07-21  6:30       ` Sam Ravnborg
2007-07-22 10:20   ` Geert Uytterhoeven
2007-07-22 22:55     ` Antonino A. Daplas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185144911.6370.1.camel@daplas \
    --to=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.