From: Richard Purdie <rpurdie@rpsys.net>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Trent Piepho <xyzzy@speakeasy.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
acpi4asus-u@pimp.vs19.net, Gabriel C <nix.or.die@googlemail.com>,
Corentin Chary <corentincj@iksaif.net>,
Andreas Gruenbacher <agruen@suse.de>
Subject: Re: [1/2] 2.6.23-rc1: known regressions
Date: Mon, 23 Jul 2007 15:32:02 +0100 [thread overview]
Message-ID: <1185201122.6148.60.camel@localhost.localdomain> (raw)
In-Reply-To: <20070723133600.GI21668@ftp.linux.org.uk>
On Mon, 2007-07-23 at 14:36 +0100, Al Viro wrote:
> On Mon, Jul 23, 2007 at 02:12:07PM +0100, Richard Purdie wrote:
> > Fix the leak where asus-led registration fails half way through.
>
> Frankly, I don't think that any post-factum checks are needed. We
> should just bail out at the point of failure. See the patch posted
> earlier... BTW, your variant does destroy_workqueue() when no
> create_singlethreaded_workqueue() had been called. FWIW, here's
> the patch I'm talking about:
I saw that after I'd posted mine. I don't mind which we use...
I'm pleased the IS_ERR(object##_led.class_dev) is gone as that makes
nasty assumptions about what the LED class does internally...
Cheers,
Richard
prev parent reply other threads:[~2007-07-23 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 9:47 [1/2] 2.6.23-rc1: known regressions Michal Piotrowski
2007-07-23 10:21 ` Al Viro
2007-07-23 11:17 ` Trent Piepho
2007-07-23 11:25 ` Al Viro
2007-07-23 13:12 ` Richard Purdie
2007-07-23 13:36 ` Al Viro
2007-07-23 14:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185201122.6148.60.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=acpi4asus-u@pimp.vs19.net \
--cc=agruen@suse.de \
--cc=corentincj@iksaif.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=nix.or.die@googlemail.com \
--cc=viro@ftp.linux.org.uk \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.