All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Staubach <staubach@redhat.com>
Cc: nfsv4@linux-nfs.org, nfs@lists.sourceforge.net,
	Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH] NFS: have string-based mount options default to "intr" mounts
Date: Wed, 25 Jul 2007 22:44:00 -0400	[thread overview]
Message-ID: <1185417840.6585.143.camel@localhost> (raw)
In-Reply-To: <46A7B450.3060304@redhat.com>

On Wed, 2007-07-25 at 16:36 -0400, Peter Staubach wrote:

> It sounds like the sync to disk on close() needs to be done in a
> separate context and have the process in close() wait on it?  That
> way, the process which received the signal could abort and return
> without waiting on all of the data to get flushed, but the data
> would still get flushed in a timely fashion?

We could do that, but what kind of extra guarantees would that provide?
The whole question is what you mean by "timely fashion" here. Normally,
I'd expect that to mean "before any locks are freed", in which case I
don't see how a separate flush context will help here...

> I suspect that as soon as you throw in a close() which returns
> EINTR, then all assumptions about close-to-open become null and
> void.

Exactly. Byte range locks will be automatically freed as part of the
POSIX close() process, and the application itself may still survive for
long enough to release other locks (dotlocks etc...) that it may hold.

Trond

  reply	other threads:[~2007-07-26  2:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25 18:56 [PATCH] NFS: have string-based mount options default to "intr" mounts Jeff Layton
2007-07-25 19:36 ` Chuck Lever
2007-07-25 19:41   ` Jeff Layton
2007-07-25 19:48     ` Chuck Lever
2007-07-25 20:16     ` Trond Myklebust
2007-07-25 20:36       ` Peter Staubach
2007-07-26  2:44         ` Trond Myklebust [this message]
2007-07-25 20:43       ` Jeff Layton
2007-07-25 21:07         ` Peter Staubach
2007-07-25 23:48           ` Jeff Layton
2007-07-25 23:51             ` Jeff Layton
  -- strict thread matches above, loose matches on Subject: below --
2007-07-25 20:05 [PATCH] NFS: have string-based mount options default to intr mounts Rick Macklem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185417840.6585.143.camel@localhost \
    --to=trond.myklebust@fys.uio.no \
    --cc=jlayton@redhat.com \
    --cc=nfs@lists.sourceforge.net \
    --cc=nfsv4@linux-nfs.org \
    --cc=staubach@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.