All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Schnell <daniel.schnell@marel.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: RE: [PATCH] mpx5200_uart: drop port lock across tty_flip_buffer() call
Date: Thu, 26 Jul 2007 11:41:18 +0200	[thread overview]
Message-ID: <1185442878.3227.23.camel@chaos> (raw)
In-Reply-To: <DD39B5C3F4963040ADC9768BE7E430CB02178125@is-hdq-exchange.marel.net>

On Thu, 2007-07-26 at 09:25 +0000, Daniel Schnell wrote:
> Thomas Gleixner wrote:
> 
> > On Wed, 2007-07-25 at 13:42 -0600, Grant Likely wrote:
> >> On 7/25/07, Thomas Gleixner <tglx@linutronix.de> wrote:
> >>> The port lock needs to be dropped across the tty_flip_buffer call,
> >>> as it would lead to a deadlock with the spin_lock(&port->lock) in
> >>> uart_start() 
> >>> 
> >>> Uncovered by lockdep / preempt-rt
> >>> 
> >>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> While you are at it 8°> ... the mpc5200-fec driver has serious
> problems with preempt-rt, similar to what the IBM emac had ....

Care to whip up a patch ?

	tglx

      reply	other threads:[~2007-07-26  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25 19:10 [PATCH] mpx5200_uart: drop port lock across tty_flip_buffer() call Thomas Gleixner
2007-07-25 19:42 ` Grant Likely
2007-07-25 19:47   ` Thomas Gleixner
2007-07-25 19:54     ` Grant Likely
2007-07-26  9:25     ` Daniel Schnell
2007-07-26  9:41       ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185442878.3227.23.camel@chaos \
    --to=tglx@linutronix.de \
    --cc=daniel.schnell@marel.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.