Re: [net-next PATCH v10 7/9] nvmem: an8855: Add support for Airoha AN8855 Switch EFUSE

[Christophe JAILLET <christophe.jaillet@wanadoo.fr>]

Le 08/12/2024 à 01:20, Christian Marangi a écrit :
> Add support for Airoha AN8855 Switch EFUSE. These EFUSE might be used
> for calibration data for the internal switch PHYs.
> 
> Signed-off-by: Christian Marangi <ansuelsmth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>   MAINTAINERS                  |  1 +
>   drivers/nvmem/Kconfig        | 11 +++++++
>   drivers/nvmem/Makefile       |  2 ++
>   drivers/nvmem/an8855-efuse.c | 63 ++++++++++++++++++++++++++++++++++++
>   4 files changed, 77 insertions(+)
>   create mode 100644 drivers/nvmem/an8855-efuse.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 38c7b2362c92..a67d147276a1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -723,6 +723,7 @@ F:	Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
>   F:	Documentation/devicetree/bindings/nvmem/airoha,an8855-efuse.yaml
>   F:	drivers/mfd/airoha-an8855.c
>   F:	drivers/net/mdio/mdio-an8855.c
> +F:	drivers/nvmem/an8855-efuse.c
>   
>   AIROHA ETHERNET DRIVER
>   M:	Lorenzo Bianconi <lorenzo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 8671b7c974b9..599014970c22 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -28,6 +28,17 @@ source "drivers/nvmem/layouts/Kconfig"
>   
>   # Devices
>   
> +config NVMEM_AN8855_EFUSE
> +	tristate "Airoha AN8855 eFuse support"
> +	depends on MFD_AIROHA_AN8855 || COMPILE_TEST
> +	help
> +	  Say y here to enable support for reading eFuses on Airoha AN8855
> +	  Switch. These are e.g. used to store factory programmed
> +	  calibration data required for the PHY.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called nvmem-apple-efuse.

nvmem-an8855-efuse?

> +
>   config NVMEM_APPLE_EFUSES
>   	tristate "Apple eFuse support"
>   	depends on ARCH_APPLE || COMPILE_TEST
> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile
> index 5b77bbb6488b..c732132c0e45 100644
> --- a/drivers/nvmem/Makefile
> +++ b/drivers/nvmem/Makefile
> @@ -10,6 +10,8 @@ nvmem_layouts-y			:= layouts.o
>   obj-y				+= layouts/
>   
>   # Devices
> +obj-$(CONFIG_NVMEM_AN8855_EFUSE)	+= nvmem-an8855-efuse.o
> +nvmem-an8855-efuse-y 			:= an8855-efuse.o
>   obj-$(CONFIG_NVMEM_APPLE_EFUSES)	+= nvmem-apple-efuses.o
>   nvmem-apple-efuses-y 			:= apple-efuses.o
>   obj-$(CONFIG_NVMEM_BCM_OCOTP)		+= nvmem-bcm-ocotp.o

...

> +static int an8855_efuse_probe(struct platform_device *pdev)
> +{
> +	struct nvmem_config an8855_nvmem_config = {
> +		.name = "an8855-efuse",
> +		.size = AN8855_EFUSE_CELL * sizeof(u32),
> +		.stride = sizeof(u32),
> +		.word_size = sizeof(u32),
> +		.reg_read = an8855_efuse_read,
> +	};
> +	struct device *dev = &pdev->dev;
> +	struct nvmem_device *nvmem;
> +
> +	/* Assign NVMEM priv to MFD regmap */
> +	an8855_nvmem_config.priv = dev_get_regmap(dev->parent, NULL);
> +	an8855_nvmem_config.dev = dev;
> +	nvmem = devm_nvmem_register(dev, &an8855_nvmem_config);
> +
> +	return PTR_ERR_OR_ZERO(nvmem);
> +}
> +
> +static const struct of_device_id an8855_efuse_of_match[] = {
> +	{ .compatible = "airoha,an8855-efuse", },
> +	{/* sentinel */},

No need for the ending comma.

> +};
> +MODULE_DEVICE_TABLE(of, an8855_efuse_of_match);

...

CJ