From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Mansley Subject: RE: compile error of HVM pv drivers Date: Mon, 30 Jul 2007 15:54:56 +0100 Message-ID: <1185807296.31234.4.camel@moonstone.uk.level5networks.com> References: <10EA09EFD8728347A513008B6B0DA77AA3EF7A@pdsmsx411.ccr.corp.intel.com> <1185806843.31234.3.camel@moonstone.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1185806843.31234.3.camel@moonstone.uk.level5networks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhao, Yunfeng" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, 2007-07-30 at 15:47 +0100, Kieran Mansley wrote: > On Mon, 2007-07-30 at 22:39 +0800, Zhao, Yunfeng wrote: > > Hi, Kieran > > I just checked 2.6.16 kernel source. > > netif_tx_lock_bh is not in the code of 2.6.16, but it is in 2.6.18 > > In that case replacing the calls (there are two in that file) to > netif_tx_lock_bh() with: > > spin_lock_bh(&vif_state->np->netdev->xmit_lock); > > And similarly the calls to netif_tx_unlock_bh() with spin_unlock_bh(), > may solve your problem. In light of Keir's reply pointing out the compat definition of netif_tx_lock_bh() this is clearly not going to help. Sorry. I thought it was an odd way of the compiler to express that error. Kieran