From: Alex Williamson <alex.williamson@hp.com>
To: Akio Takebe <takebe_akio@jp.fujitsu.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
xen-ia64-devel <xen-ia64-devel@lists.xensource.com>
Subject: Re: [Xen-ia64-devel] [Patch 0/3] Disable ACPI SRAT, SLIT on dom0 <take 3>
Date: Mon, 30 Jul 2007 09:31:09 -0600 [thread overview]
Message-ID: <1185809469.6802.4.camel@bling> (raw)
In-Reply-To: <9DC7D233B07103takebe_akio@jp.fujitsu.com>
On Mon, 2007-07-30 at 07:56 +0900, Akio Takebe wrote:
>
> diff -r 4492a0285bae -r 7e81d7ec1bb9 tools/libxc/ia64/Makefile
> --- a/tools/libxc/ia64/Makefile Fri Jul 27 08:15:16 2007 -0600
> +++ b/tools/libxc/ia64/Makefile Mon Jul 30 07:17:24 2007 +0900
> @@ -5,7 +5,7 @@ GUEST_SRCS-y += ia64/xc_ia64_linux_resto
> GUEST_SRCS-y += ia64/xc_ia64_linux_restore.c
>
> GUEST_SRCS-y += ia64/xc_dom_ia64_util.c
> -DOMFW_SRCS_BASE := dom_fw_common.c dom_fw_domu.c dom_fw_asm.S
> +DOMFW_SRCS_BASE := dom_fw_common.c dom_fw_domu.c dom_fw_asm.S
> dom_fw_acpi.c
> DOMFW_SRCS := $(addprefix ia64/, $(DOMFW_SRCS_BASE))
> $(DOMFW_SRCS):
> ln -sf ../$(XEN_ROOT)/xen/arch/ia64/xen/$(@F) $@
This doesn't build. DOMFW_SRCS_BASE is used as the list of base file
names that get linked from the xen tree. This file needs to be built
from the local copy. Adding the the GUEST_SRCS-y list is the way to
make that happen. Keir, please apply the patch below to fix the ia64
build in staging. Thanks,
Alex
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
diff -r 9cd309378326 tools/libxc/ia64/Makefile
--- a/tools/libxc/ia64/Makefile Mon Jul 30 11:28:16 2007 +0100
+++ b/tools/libxc/ia64/Makefile Mon Jul 30 09:07:14 2007 -0600
@@ -5,7 +5,9 @@ GUEST_SRCS-y += ia64/xc_ia64_linux_resto
GUEST_SRCS-y += ia64/xc_ia64_linux_restore.c
GUEST_SRCS-y += ia64/xc_dom_ia64_util.c
-DOMFW_SRCS_BASE := dom_fw_common.c dom_fw_domu.c dom_fw_asm.S dom_fw_acpi.c
+GUEST_SRCS-y += ia64/dom_fw_acpi.c
+
+DOMFW_SRCS_BASE := dom_fw_common.c dom_fw_domu.c dom_fw_asm.S
DOMFW_SRCS := $(addprefix ia64/, $(DOMFW_SRCS_BASE))
$(DOMFW_SRCS):
ln -sf ../$(XEN_ROOT)/xen/arch/ia64/xen/$(@F) $@
next prev parent reply other threads:[~2007-07-30 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 22:52 [Patch 0/3] Disable ACPI SRAT, SLIT on dom0 <take 3> Akio Takebe
2007-07-29 22:56 ` Akio Takebe
2007-07-30 15:31 ` Alex Williamson [this message]
2007-07-29 22:58 ` [Xen-devel] " Akio Takebe
2007-07-29 23:00 ` Akio Takebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185809469.6802.4.camel@bling \
--to=alex.williamson@hp.com \
--cc=takebe_akio@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
--cc=xen-ia64-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.