Re: [PATCH/RFC] Allow selected nodes to be excluded from MPOL_INTERLEAVE masks

[Lee Schermerhorn <Lee.Schermerhorn@hp.com>]

On Mon, 2007-07-30 at 11:29 -0700, Christoph Lameter wrote:
> On Mon, 30 Jul 2007, Lee Schermerhorn wrote:
> 
> > +	return 0;
> > +}
> > +early_param("no_interleave_nodes", setup_no_interleave_nodes);
> > +
> >  /* The value user specified ....changed by config */
> >  static int user_zonelist_order = ZONELIST_ORDER_DEFAULT;
> >  /* string for sysctl */
> > @@ -2410,8 +2435,15 @@ static int __build_all_zonelists(void *d
> >  		build_zonelists(pgdat);
> >  		build_zonelist_cache(pgdat);
> >  
> > -		if (pgdat->node_present_pages)
> > +		if (pgdat->node_present_pages) {
> >  			node_set_state(nid, N_MEMORY);
> > +			/*
> > +			 * Only nodes with memory are valid for MPOL_INTERLEAVE,
> > +			 * but maybe not all of them?
> > +			 */
> > +			if (!node_isset(nid, no_interleave_nodes))
> > +				node_set_state(nid, N_INTERLEAVE);
> 
> 			else
> 			 printk ....
> 
> would be better since it will only list the nodes that have memory and are 
> excluded from interleave.

You mean instead of just listing the no_interleave_nodes node list
argument which might contain memoryless nodes? 

I'll fix that up on next respin.

Lee

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>