All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 11/11] modules: better error messages when modules fail to load due to a sysfs problem.
Date: Mon, 30 Jul 2007 15:09:33 -0700	[thread overview]
Message-ID: <1185833416410-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <11858334123619-git-send-email-gregkh@suse.de>

This helps people when debugging problems like the ones that were in the
recent -mm releases.


Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 kernel/params.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index effbaae..4e57732 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -567,7 +567,12 @@ static void __init kernel_param_sysfs_setup(const char *name,
 	kobject_set_name(&mk->kobj, name);
 	kobject_init(&mk->kobj);
 	ret = kobject_add(&mk->kobj);
-	BUG_ON(ret < 0);
+	if (ret) {
+		printk(KERN_ERR "Module '%s' failed to be added to sysfs, "
+		      "error number %d\n", name, ret);
+		printk(KERN_ERR	"The system will be unstable now.\n");
+		return;
+	}
 	param_sysfs_setup(mk, kparam, num_params, name_skip);
 	kobject_uevent(&mk->kobj, KOBJ_ADD);
 }
-- 
1.5.2.2


      reply	other threads:[~2007-07-30 22:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 22:08 [GIT PATCH] driver core fixes for 2.6.23-rc1 Greg KH
2007-07-30 22:09 ` [PATCH 01/11] HOWTO: adjust translation header of Japanese stable_api_nonsense.txt Greg Kroah-Hartman
2007-07-30 22:09   ` [PATCH 02/11] HOWTO: sync Japanese HOWTO Greg Kroah-Hartman
2007-07-30 22:09     ` [PATCH 03/11] kobject: fix link error when CONFIG_HOTPLUG is disabled Greg Kroah-Hartman
2007-07-30 22:09       ` [PATCH 04/11] kobject: put kobject_actions in kobject.h Greg Kroah-Hartman
2007-07-30 22:09         ` [PATCH 05/11] kernel-doc fixes for PCI and drivers/base/ Greg Kroah-Hartman
2007-07-30 22:09           ` [PATCH 06/11] Fix Doc/sysfs-rules typos Greg Kroah-Hartman
2007-07-30 22:09             ` [PATCH 07/11] stable_api_nonsense.txt: Disambiguate the use of "this" by using "that" to refer to the syscall interface Greg Kroah-Hartman
2007-07-30 22:09               ` [PATCH 08/11] driver core: revert "device" link creation check Greg Kroah-Hartman
2007-07-30 22:09                 ` [PATCH 09/11] kset: kernel-doc cleanups Greg Kroah-Hartman
2007-07-30 22:09                   ` [PATCH 10/11] kobject: update documentation Greg Kroah-Hartman
2007-07-30 22:09                     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185833416410-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.