From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chandra Seetharaman Subject: Re: [patch 1/3] Extremely basic hp hardware handler (no retries, no error handling, etc). Date: Mon, 30 Jul 2007 16:27:15 -0700 Message-ID: <1185838035.17399.80.camel@linuxchandra> References: <20070726044447.846195205@redhat.com> <20070726044720.403731599@redhat.com> <1185476962.17399.52.camel@linuxchandra> <46AE5353.2050002@cs.wisc.edu> Reply-To: sekharan@us.ibm.com, device-mapper development Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46AE5353.2050002@cs.wisc.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Christie Cc: device-mapper development List-Id: dm-devel.ids On Mon, 2007-07-30 at 16:08 -0500, Mike Christie wrote: > Chandra Seetharaman wrote: > > Hi Dave, > > > > some coding style related comments (below). > > > > > >> + if (!error) { > >> + err_flags = 0; > >> + DMDEBUG("%s path activation command - success", > >> + path->dev->name); > > > > Mixed use of space and tab for indentation (many other places too). > > > > Where is that rule for this type of plcae? Documentation/CodingStyle: "Outside of comments, documentation and except in Kconfig, spaces are never used for indentation, and the above example is deliberately broken." > > I think that is fine in those types of places. In fact I would leave it > with mixed because that is how the rest of the dm code does it. > > > >> + memset(&req->cmd, 0, BLK_MAX_CDB); > >> + req->cmd[0] = START_STOP; > >> + req->cmd[4] = 1; > >> + req->cmd_len = COMMAND_SIZE(req->cmd[0]); > >> + out: > > > > I think there will be no space before the label (one more below). > > > > Either is normally fine, but in this case to fit with the other dm code > that is best. It is not explicitly stated in CodingStyle. But, the example under "goto" section does have the label start at column 0 (that is why I said "I think" :). -- ---------------------------------------------------------------------- Chandra Seetharaman | Be careful what you choose.... - sekharan@us.ibm.com | .......you may get it. ----------------------------------------------------------------------