All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: greearb@candelatech.com, kaber@trash.net, netdev@vger.kernel.org,
	mcarlson@broadcom.com
Subject: Re: RFC: on [ab]use of skb->cb by VLAN code
Date: Mon, 30 Jul 2007 22:02:04 -0400	[thread overview]
Message-ID: <1185847324.5162.31.camel@localhost> (raw)
In-Reply-To: <20070730.183337.27784025.davem@davemloft.net>

On Mon, 2007-30-07 at 18:33 -0700, David Miller wrote:

> I understand the concern, but how much qdisc stuff can possibly
> happen between those two ->hard_start_xmit() calls and do we
> want to support that in any way anyways?

>From a quick glance only netem seems to use it in the fast path (in a
legit way)
Theoretically, you could have many generations (i.e parents and
children, grandchildren etc) of netdevices stacked on top of each other
each with qdiscs. In a simple example: dont know how well these days
Vlans->bonding->somehardwarenetdevice works. 
Redirect will could also result in a graph of unrelated netdevices (and
it is fair game to trample on cb anywhere along the path)
I came across the issue because i used cb in batching to store transient
state which is used between qdisc dequeueing and hardware enqueueing
(looked and smelled legit to me).
 
> The only alternative I see is to add more things to struct sk_buff
> and that's usually very unpopular :-)

I know ;-> Thats why i asked the question.

cheers,
jamal


  reply	other threads:[~2007-07-31  2:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31  0:59 RFC: on [ab]use of skb->cb by VLAN code jamal
2007-07-31  1:33 ` David Miller
2007-07-31  2:02   ` jamal [this message]
2007-07-31  2:06     ` David Miller
2007-07-31  4:30       ` Ben Greear
2007-07-31  5:18         ` David Miller
2007-07-31  5:33           ` Ben Greear
2007-07-31 16:56             ` Rick Jones
2007-07-31 17:50               ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185847324.5162.31.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=kaber@trash.net \
    --cc=mcarlson@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.