From: David Vrabel <david.vrabel@csr.com>
To: linux-kernel@vger.kernel.org
Cc: David Vrabel <david.vrabel@csr.com>,
Pierre Ossman <drzeus-list@drzeus.cx>
Subject: sdio: parameterize SDIO FBR register defines
Date: Tue, 31 Jul 2007 16:36:31 +0100 [thread overview]
Message-ID: <11858961931710-git-send-email-david.vrabel@csr.com> (raw)
In-Reply-To: <11858961933491-git-send-email-david.vrabel@csr.com>
Signed-off-by: David Vrabel <david.vrabel@csr.com>
---
commit 51755c3d59be1ba778bef45888f9f5e341dc4af4
tree c7bbb562b2d801197eefb619a17c94467c1299cd
parent 1cf0b6019aa3916197eecafe058bd2f3d700d24a
author David Vrabel <david.vrabel@csr.com> Mon, 30 Jul 2007 19:20:59 +0100
committer David Vrabel <dvrabel@cantab.net> Mon, 30 Jul 2007 19:28:30 +0100
drivers/mmc/core/sdio.c | 4 ++--
drivers/mmc/core/sdio_cis.c | 2 +-
include/linux/mmc/sdio.h | 16 +++++++++-------
3 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 6589fd6..08f579c 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -30,7 +30,7 @@ static int sdio_read_fbr(struct sdio_func *func)
unsigned char data;
ret = mmc_io_rw_direct(func->card, 0, 0,
- func->num * 0x100 + SDIO_FBR_STD_IF, 0, &data);
+ SDIO_FBR_STD_IF(func->num), 0, &data);
if (ret != MMC_ERR_NONE)
goto out;
@@ -38,7 +38,7 @@ static int sdio_read_fbr(struct sdio_func *func)
if (data == 0x0f) {
ret = mmc_io_rw_direct(func->card, 0, 0,
- func->num * 0x100 + SDIO_FBR_STD_IF_EXT, 0, &data);
+ SDIO_FBR_STD_IF_EXT(func->num), 0, &data);
if (ret != MMC_ERR_NONE)
goto out;
}
diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
index b0c6697..8aa4666 100644
--- a/drivers/mmc/core/sdio_cis.c
+++ b/drivers/mmc/core/sdio_cis.c
@@ -215,7 +215,7 @@ int sdio_read_cis(struct sdio_func *func, unsigned int fn)
for (i = 0; i < 3; i++) {
unsigned char x;
ret = mmc_io_rw_direct(func->card, 0, 0,
- fn * 0x100 + SDIO_FBR_CIS + i, 0, &x);
+ SDIO_FBR_CIS(fn) + i, 0, &x);
if (ret != MMC_ERR_NONE)
return -EIO;
ptr |= x << (i * 8);
diff --git a/include/linux/mmc/sdio.h b/include/linux/mmc/sdio.h
index 145ce23..e2bda4b 100644
--- a/include/linux/mmc/sdio.h
+++ b/include/linux/mmc/sdio.h
@@ -132,26 +132,28 @@
* Function Basic Registers (FBR)
*/
-#define SDIO_FBR_STD_IF 0x00
+#define __SDIO_FBR(f, r) ((f) * 0x100 + (r))
+
+#define SDIO_FBR_STD_IF(f) __SDIO_FBR((f), 0x00)
#define SDIO_FBR_SUPPORTS_CSA 0x40 /* supports Code Storage Area */
#define SDIO_FBR_ENABLE_CSA 0x80 /* enable Code Storage Area */
-#define SDIO_FBR_STD_IF_EXT 0x01
+#define SDIO_FBR_STD_IF_EXT(f) __SDIO_FBR((f), 0x01)
-#define SDIO_FBR_POWER 0x02
+#define SDIO_FBR_POWER(f) __SDIO_FBR((f), 0x02)
#define SDIO_FBR_POWER_SPS 0x01 /* Supports Power Selection */
#define SDIO_FBR_POWER_EPS 0x02 /* Enable (low) Power Selection */
-#define SDIO_FBR_CIS 0x09 /* CIS pointer (3 bytes) */
+#define SDIO_FBR_CIS(f) __SDIO_FBR((f), 0x09) /* CIS pointer (3 bytes) */
-#define SDIO_FBR_CSA 0x0C /* CSA pointer (3 bytes) */
+#define SDIO_FBR_CSA(f) __SDIO_FBR((f), 0x0C) /* CSA pointer (3 bytes) */
-#define SDIO_FBR_CSA_DATA 0x0F
+#define SDIO_FBR_CSA_DATA(f) __SDIO_FBR((f), 0x0F)
-#define SDIO_FBR_BLKSIZE 0x10 /* block size (2 bytes) */
+#define SDIO_FBR_BLKSIZE(f) __SDIO_FBR((f), 0x10) /* block size (2 bytes) */
#endif
next prev parent reply other threads:[~2007-07-31 16:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 15:36 sdio: enhance IO_RW_EXTENDED support David Vrabel
2007-07-31 15:36 ` David Vrabel [this message]
2007-08-04 13:26 ` sdio: parameterize SDIO FBR register defines Pierre Ossman
2007-08-06 10:14 ` David Vrabel
2007-08-06 14:58 ` Pierre Ossman
2007-07-31 15:36 ` sdio: set the functions' block size David Vrabel
2007-08-04 13:30 ` Pierre Ossman
2007-08-06 10:04 ` David Vrabel
2007-07-31 15:36 ` sdio: extend sdio_readsb() and friends to handle any length of buffer David Vrabel
2007-08-04 13:35 ` Pierre Ossman
2007-08-04 13:23 ` sdio: enhance IO_RW_EXTENDED support Pierre Ossman
2007-08-06 10:31 ` David Vrabel
2007-08-06 15:12 ` Pierre Ossman
2007-08-06 15:32 ` David Vrabel
2007-08-06 18:06 ` Pierre Ossman
2007-08-06 20:01 ` Pierre Ossman
2007-08-07 12:51 ` David Vrabel
2007-08-07 12:53 ` [patch 1/4] sdio: parameterize SDIO FBR register defines David Vrabel
2007-08-07 12:54 ` [patch 2/4] sdio: set the functions' block size David Vrabel
2007-08-07 13:38 ` Pierre Ossman
2007-08-07 17:20 ` David Vrabel
2007-08-07 17:54 ` Pierre Ossman
2007-08-08 9:46 ` David Vrabel
2007-08-08 10:06 ` Pierre Ossman
2007-08-08 10:19 ` David Vrabel
2007-08-07 12:55 ` [patch 3/4] sdio: extend sdio_readsb() and friends to handle any length of buffer David Vrabel
2007-08-07 13:42 ` Pierre Ossman
2007-08-07 20:17 ` Pierre Ossman
2007-08-08 10:19 ` David Vrabel
2007-08-08 10:37 ` Pierre Ossman
2007-08-08 13:22 ` David Vrabel
2007-08-08 13:23 ` [patch 1/3] sdio: add SDIO_FBR_BASE(f) macro David Vrabel
2007-08-08 13:23 ` [patch 2/3] sdio: set the functions' block size David Vrabel
2007-08-08 13:24 ` [patch 3/3] sdio: extend sdio_readsb() and friends to handle any length of buffer David Vrabel
2007-08-08 16:55 ` [patch 3/4] " Pierre Ossman
2007-08-07 12:55 ` [patch 4/4] sdio: disable CD resistor David Vrabel
2007-08-07 13:43 ` Pierre Ossman
2007-08-07 14:46 ` David Vrabel
2007-08-07 15:08 ` Pierre Ossman
2007-08-07 13:33 ` sdio: enhance IO_RW_EXTENDED support Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11858961931710-git-send-email-david.vrabel@csr.com \
--to=david.vrabel@csr.com \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.