From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2] Remove unused HIF_ABORTED flag
Date: Wed, 01 Aug 2007 14:08:17 +0100 [thread overview]
Message-ID: <1185973697.8765.644.camel@quoit> (raw)
From 8a74a33fecdf651e02efb705adef2d93dc7752e8 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 1 Aug 2007 11:08:29 +0100
Subject: [PATCH] [GFS2] Remove unused HIF_ABORTED flag
We never try to wait for a gfs2_holder which has returned -EINVAL
when initially queued, so that the HIF_ABORTED flag is not needed.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index fd8cf02..5e2c269 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -881,9 +881,6 @@ static int glock_wait_internal(struct gfs2_holder *gh)
struct gfs2_glock *gl = gh->gh_gl;
struct gfs2_sbd *sdp = gl->gl_sbd;
- if (test_bit(HIF_ABORTED, &gh->gh_iflags))
- return -EIO;
-
if (gh->gh_flags & (LM_FLAG_TRY | LM_FLAG_TRY_1CB)) {
spin_lock(&gl->gl_spin);
if (gl->gl_req_gh != gh &&
@@ -996,10 +993,8 @@ int gfs2_glock_nq(struct gfs2_holder *gh)
int error = 0;
restart:
- if (unlikely(test_bit(SDF_SHUTDOWN, &sdp->sd_flags))) {
- set_bit(HIF_ABORTED, &gh->gh_iflags);
+ if (unlikely(test_bit(SDF_SHUTDOWN, &sdp->sd_flags)))
return -EIO;
- }
spin_lock(&gl->gl_spin);
add_to_queue(gh);
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 1d90ff1..cc5ca58 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -135,7 +135,6 @@ enum {
/* States */
HIF_HOLDER = 6,
- HIF_ABORTED = 9,
HIF_WAIT = 10,
};
--
1.5.1.2
reply other threads:[~2007-08-01 13:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185973697.8765.644.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.