From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Updated patch to add SBC8641D
Date: Mon, 06 Aug 2007 11:34:07 -0500 [thread overview]
Message-ID: <1186418047.5970.2.camel@ld0161-tx32> (raw)
In-Reply-To: <20070806154320.3A5943535DD@atlas.denx.de>
On Mon, 2007-08-06 at 10:43, Wolfgang Denk wrote:
> In message <1186410458.22362.8.camel@server> you wrote:
> > Add support for Wind River's SBC8641D reference board.
> >
> > Resend to add fixes per JDL.
> >
> > Signed-off by: Joe Hamman <joe.hamman@embeddedspecialties.com>
>
> Please explain why you are changing drivers/tsec.h in this patch?
>
> Are you fixing a bug? If yes, then this should be submitted as a
> separate patch and not be hidden within bug board support patches.
Hmmm... This isn't really a bug fix. It is really
more of a board-specific adjustment for PHY association
with the controllers on your board, right?
So, it seems like this should be made board dependent somehow.
Or, it seems like we might have Andy talk to us about the
future of Ed's TSEC patches for multiple PHY and TBI support.
This _might_ be subsumed by that effort, but I'm not sure.
jdl
next prev parent reply other threads:[~2007-08-06 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 14:27 [U-Boot-Users] [PATCH 2/2] Updated patch to add SBC8641D Joe Hamman
2007-08-06 15:43 ` Wolfgang Denk
2007-08-06 16:34 ` Jon Loeliger [this message]
2007-08-06 16:55 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186418047.5970.2.camel@ld0161-tx32 \
--to=jdl@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.