All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Paul Menage <menage@google.com>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.com,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	ckrm-tech@lists.sourceforge.net
Subject: Re: [ckrm-tech] Circular Locking Dependency Chain detected in containers code
Date: Tue, 07 Aug 2007 22:23:28 +0200	[thread overview]
Message-ID: <1186518208.11797.176.camel@lappy> (raw)
In-Reply-To: <6599ad830708071310i4fa7a98age169e2d650421d8b@mail.gmail.com>

On Tue, 2007-08-07 at 13:10 -0700, Paul Menage wrote:
> I'm away from work at the moment and can't investigate fully, but it
> looks as though this may be the same one that I mentioned in the
> introductory email to the patchset. If so, it's a false positive -
> there's a point in the container mount code where we need to lock a
> newly-created (and hence guaranteed unlocked) directory inode while
> holding container mutex. This makes the lockdep code think that
> inode->i_mutex nests inside container_mutex, when in fact
> container_mutex nests outside inode->i_mutex in all cases except this
> one case where i_mutex can't possibly be locked.
> 
> I've not learned enough about lockdep yet to figure out how to shut it
> up in this case.

The typical annotation would be using spin_lock_nested/mutex_lock_nested
with a non-0 nesting level for this one case.


  reply	other threads:[~2007-08-07 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07  6:26 Circular Locking Dependency Chain detected in containers code Dhaval Giani
2007-08-07 20:10 ` [ckrm-tech] " Paul Menage
2007-08-07 20:23   ` Peter Zijlstra [this message]
2007-08-07 20:25     ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186518208.11797.176.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.com \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.