From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.nokia.com ([131.228.20.172] helo=mgw-ext13.nokia.com)
	by canuck.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux))
	id 1IIpRJ-0001RQ-C8
	for linux-mtd@lists.infradead.org; Wed, 08 Aug 2007 13:35:25 -0400
Subject: Re: [Patch 05/18] fs/logfs/dir.c
From: Artem Bityutskiy <dedekind@infradead.org>
To: =?ISO-8859-1?Q?J=F6rn?= Engel <joern@logfs.org>
In-Reply-To: <20070808171554.GV15319@lazybastard.org>
References: <20070808161234.GB15319@lazybastard.org>
	<20070808161626.GG15319@lazybastard.org>
	<1186592854.19606.49.camel@sauron>
	<20070808171554.GV15319@lazybastard.org>
Content-Type: text/plain; charset=utf-8
Date: Wed, 08 Aug 2007 20:34:34 +0300
Message-Id: <1186594474.19606.52.camel@sauron>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Cc: akpm@osdl.org, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>, David Woodhouse <dwmw2@infradead.org>
Reply-To: dedekind@infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Wed, 2007-08-08 at 19:15 +0200, J=C3=B6rn Engel wrote:
> On Wed, 8 August 2007 20:07:34 +0300, Artem Bityutskiy wrote:
> > On Wed, 2007-08-08 at 18:16 +0200, J=C3=B6rn Engel wrote:
> > > +static inline void logfs_inc_count(struct inode *inode)
> > > +{
> > > +	inode->i_nlink++;
> > > +	mark_inode_dirty_sync(inode);
> > > +}
> > > +
> > > +static inline void logfs_dec_count(struct inode *inode)
> > > +{
> > > +	inode->i_nlink--;
> > > +	mark_inode_dirty_sync(inode);
> > > +}
> > include/linux/fs.h: inode_inc_link_count() inode_dec_link_count() do
> > this. Although not sure they exist in the old kernel your patches are
> > against.
>=20
> Almost, they call mark_inode_dirty() instead of mark_inode_dirty_sync().
> I wonder if that's necessary.
>=20
Ah, right, it is necessary as long as you do not have write-back
implemented, sure. Pardon :-)

--=20
Best regards,
Artem Bityutskiy (=D0=91=D0=B8=D1=82=D1=8E=D1=86=D0=BA=D0=B8=D0=B9 =D0=90=
=D1=80=D1=82=D1=91=D0=BC)

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Bityutskiy <dedekind@infradead.org>
Subject: Re: [Patch 05/18] fs/logfs/dir.c
Date: Wed, 08 Aug 2007 20:34:34 +0300
Message-ID: <1186594474.19606.52.camel@sauron>
References: <20070808161234.GB15319@lazybastard.org>
	<20070808161626.GG15319@lazybastard.org>
	<1186592854.19606.49.camel@sauron>
	<20070808171554.GV15319@lazybastard.org>
Reply-To: dedekind@infradead.org
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: akpm@osdl.org, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>, David Woodhouse <dwmw2@infradead.org>
To: =?ISO-8859-1?Q?J=F6rn?= Engel <joern@logfs.org>
Return-path: <linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org>
In-Reply-To: <20070808171554.GV15319@lazybastard.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>
Sender: linux-mtd-bounces@lists.infradead.org
Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org+gldm-linux-mtd-36=gmane.org@lists.infradead.org
List-Id: linux-fsdevel.vger.kernel.org

T24gV2VkLCAyMDA3LTA4LTA4IGF0IDE5OjE1ICswMjAwLCBKw7ZybiBFbmdlbCB3cm90ZToKPiBP
biBXZWQsIDggQXVndXN0IDIwMDcgMjA6MDc6MzQgKzAzMDAsIEFydGVtIEJpdHl1dHNraXkgd3Jv
dGU6Cj4gPiBPbiBXZWQsIDIwMDctMDgtMDggYXQgMTg6MTYgKzAyMDAsIErDtnJuIEVuZ2VsIHdy
b3RlOgo+ID4gPiArc3RhdGljIGlubGluZSB2b2lkIGxvZ2ZzX2luY19jb3VudChzdHJ1Y3QgaW5v
ZGUgKmlub2RlKQo+ID4gPiArewo+ID4gPiArCWlub2RlLT5pX25saW5rKys7Cj4gPiA+ICsJbWFy
a19pbm9kZV9kaXJ0eV9zeW5jKGlub2RlKTsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGlj
IGlubGluZSB2b2lkIGxvZ2ZzX2RlY19jb3VudChzdHJ1Y3QgaW5vZGUgKmlub2RlKQo+ID4gPiAr
ewo+ID4gPiArCWlub2RlLT5pX25saW5rLS07Cj4gPiA+ICsJbWFya19pbm9kZV9kaXJ0eV9zeW5j
KGlub2RlKTsKPiA+ID4gK30KPiA+IGluY2x1ZGUvbGludXgvZnMuaDogaW5vZGVfaW5jX2xpbmtf
Y291bnQoKSBpbm9kZV9kZWNfbGlua19jb3VudCgpIGRvCj4gPiB0aGlzLiBBbHRob3VnaCBub3Qg
c3VyZSB0aGV5IGV4aXN0IGluIHRoZSBvbGQga2VybmVsIHlvdXIgcGF0Y2hlcyBhcmUKPiA+IGFn
YWluc3QuCj4gCj4gQWxtb3N0LCB0aGV5IGNhbGwgbWFya19pbm9kZV9kaXJ0eSgpIGluc3RlYWQg
b2YgbWFya19pbm9kZV9kaXJ0eV9zeW5jKCkuCj4gSSB3b25kZXIgaWYgdGhhdCdzIG5lY2Vzc2Fy
eS4KPiAKQWgsIHJpZ2h0LCBpdCBpcyBuZWNlc3NhcnkgYXMgbG9uZyBhcyB5b3UgZG8gbm90IGhh
dmUgd3JpdGUtYmFjawppbXBsZW1lbnRlZCwgc3VyZS4gUGFyZG9uIDotKQoKLS0gCkJlc3QgcmVn
YXJkcywKQXJ0ZW0gQml0eXV0c2tpeSAo0JHQuNGC0Y7RhtC60LjQuSDQkNGA0YLRkdC8KQoKCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51
eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv
bWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==