Re: [PATCH] arm64: dts: Fix TPM schema violations

["Heiko Stübner" <heiko@sntech.de>]

Hi Lukas,

Am Samstag, 13. Januar 2024, 19:06:56 CET schrieb Lukas Wunner:
> Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS
> bindings"), several issues are reported by "make dtbs_check" for arm64
> devicetrees:
> 
> The compatible property needs to contain the chip's name in addition to
> the generic "tcg,tpm_tis-spi" and the nodename needs to be "tpm@0"
> rather than "cr50@0":
> 
>   tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
>         from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#
> 
>   cr50@0: $nodename:0: 'cr50@0' does not match '^tpm(@[0-9a-f]+)?$'
>         from schema $id: http://devicetree.org/schemas/tpm/google,cr50.yaml#
> 
> Fix these schema violations.
> 
> phyGATE-Tauri uses an Infineon SLB9670:
> https://lore.kernel.org/all/ab45c82485fa272f74adf560cbb58ee60cc42689.camel@phytec.de/
> 
> Gateworks Venice uses an Atmel ATTPM20P:
> https://trac.gateworks.com/wiki/tpm
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
> The commit mentioned above, 26c9d152ebf3 ("dt-bindings: tpm: Consolidate
> TCG TIS bindings") landed in Linus' tree yesterday.
> 
> Because this consists only of fixes, I think it could be picked up and
> forwarded to Linus at any time, even outside the merge window.
> 
> The issues reported for imx8m*-venice-gw7*xx.dts* devicetrees will not
> go away until Jarrko picks up this amendment patch for the dt-bindings:
> https://lore.kernel.org/all/8886271d52025065eddf5915bb7778ab14362255.1705140898.git.lukas@wunner.de/
> 
>  arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts    | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts         | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts      | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 2 +-
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi              | 2 +-
>  arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi            | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts             | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi        | 2 +-

you might want to split this per sub-architecture perhaps (freescale,
mediatek, rockchip) as such dts changes normally go through the trees
of the subarchitecture maintainers.


For the rockchip-parts itself, I'm also fine with them going through
somewhere else - gru devices are pretty much "finished" by now,
so for the rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>


Heiko