All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Paul Jackson <pj@sgi.com>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Question:  cpuset_update_task_memory_state() and mmap_sem ???
Date: Mon, 13 Aug 2007 15:38:22 -0400	[thread overview]
Message-ID: <1187033902.5592.33.camel@localhost> (raw)

In the comment block for the subject function in cpuset.c, it notes that
"This routine also might acquire callback_mutex and
current->mm->mmap_sem."

Is this is a stale comment?  I can't find any path from this function to
a down_{read|write}() on the caller's mmap_sem [in 23-rc2-mm2].  I
suspect that one would have noticed, as
cpuset_update_task_memory_state() is called from
alloc_page_vma() which, according to its comment block, can only be
called with the mmap_sem held [for read, at least].

Lee

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2007-08-13 19:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 19:38 Lee Schermerhorn [this message]
2007-08-16  6:06 ` Question: cpuset_update_task_memory_state() and mmap_sem ??? Paul Jackson
2007-08-16 13:12   ` Lee Schermerhorn
2007-08-16 15:43     ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187033902.5592.33.camel@localhost \
    --to=lee.schermerhorn@hp.com \
    --cc=linux-mm@kvack.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.