From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Tue, 14 Aug 2007 11:18:43 +0100 Subject: [Cluster-devel] Re: [PATCH 1/2] gfs2: use list_for_each_entry instead In-Reply-To: <11867992283116-git-send-email-crquan@gmail.com> References: <11867992283116-git-send-email-crquan@gmail.com> Message-ID: <1187086723.8765.840.camel@quoit> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Both of these patches are now in the -nmw git tree. Thanks, Steve. On Sat, 2007-08-11 at 10:27 +0800, Denis Cheng wrote: > Signed-off-by: Denis Cheng > --- > fs/gfs2/ops_fstype.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c > index cf5aa50..8d3389f 100644 > --- a/fs/gfs2/ops_fstype.c > +++ b/fs/gfs2/ops_fstype.c > @@ -818,7 +818,6 @@ static struct super_block* get_gfs2_sb(const char *dev_name) > struct nameidata nd; > struct file_system_type *fstype; > struct super_block *sb = NULL, *s; > - struct list_head *l; > int error; > > error = path_lookup(dev_name, LOOKUP_FOLLOW, &nd); > @@ -830,8 +829,7 @@ static struct super_block* get_gfs2_sb(const char *dev_name) > error = vfs_getattr(nd.mnt, nd.dentry, &stat); > > fstype = get_fs_type("gfs2"); > - list_for_each(l, &fstype->fs_supers) { > - s = list_entry(l, struct super_block, s_instances); > + list_for_each_entry(s, &fstype->fs_supers, s_instances) { > if ((S_ISBLK(stat.mode) && s->s_dev == stat.rdev) || > (S_ISDIR(stat.mode) && s == nd.dentry->d_inode->i_sb)) { > sb = s;