From: Evan Phoenix <evan@fallingsnow.net>
To: git@vger.kernel.org
Cc: Evan Phoenix <evan@fallingsnow.net>
Subject: [PATCH] A more sensible error message why 'git rebase --continue' failed
Date: Sun, 19 Aug 2007 18:13:38 -0700 [thread overview]
Message-ID: <11875724181583-git-send-email-evan@fallingsnow.net> (raw)
The current message is a bit cryptic, indicating that only changes which contained
merge conflicts should be added to the index, but in fact, all outstanding
changes must be.
The change could also incorporate a -i that prompts the user and performs
'git add -u' if they wish, allowing the rebase to properly continue.
Signed-off-by: Evan Phoenix <evan@fallingsnow.net>
diff --git a/git-rebase.sh b/git-rebase.sh
index cbafa14..c67f29a 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -135,8 +135,12 @@ do
case "$1" in
--continue)
git diff-files --quiet || {
- echo "You must edit all merge conflicts and then"
- echo "mark them as resolved using git add"
+ echo "Unable to continue rebase:"
+ echo " All modified files must be added to index first."
+ echo " Use 'git add' to resolve them and add them to the index."
+ echo
+ echo "Outstanding files:"
+ git diff-files --name-status
exit 1
}
if test -d "$dotest"
--
1.5.3.rc5.41.gc1c22
next reply other threads:[~2007-08-20 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 1:13 Evan Phoenix [this message]
2007-08-20 6:25 ` [PATCH] A more sensible error message why 'git rebase --continue' failed Junio C Hamano
2007-08-20 7:10 ` Evan Phoenix
2007-08-20 13:59 ` Steven Grimm
2007-08-20 9:35 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11875724181583-git-send-email-evan@fallingsnow.net \
--to=evan@fallingsnow.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.