From: Ed Swarthout <ed.swarthout@hwdebug.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fsl_pci_init - Remove self PCSRBAR allocation
Date: Mon, 20 Aug 2007 23:55:33 -0500 [thread overview]
Message-ID: <11876721332262-git-send-email-ed.swarthout@hwdebug.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708200942240.25897@blarg.am.freescale.net>
From: Ed Swarthout <Ed.Swarthout@freescale.com>
CPU physical address space was being wasted by allocating a
PCSRBAR PCI inbound region to it's memory space.
As a rule, PCSRBAR should be left alone since it does not affect
transactions from self and other masters may have changed it.
Signed-off-by: Ed Swarthout <ed.swarthout@freescale.com>
---
Was: {PATCH] Fix MPC8544DS PCIe3 scsi.
This fixes the MPC8544DS scsi error:
SCSI: scanning bus for devices...
Invaild port number 1
Invaild port number 2
Invaild port number 3
when not enough PCIe3 memory space is available for allocation.
This replaces k's temp hack.
drivers/fsl_pci_init.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/fsl_pci_init.c b/drivers/fsl_pci_init.c
index 1084dc6..3a13eea 100644
--- a/drivers/fsl_pci_init.c
+++ b/drivers/fsl_pci_init.c
@@ -130,9 +130,14 @@ fsl_pci_init(struct pci_controller *hose)
}
- /* Call setup to allocate PCSRBAR window */
- pciauto_setup_device(hose, dev, 1, hose->pci_mem,
+ /* Use generic setup_device to initialize standard pci regs,
+ * but do not allocate any windows since any BAR found (such
+ * as PCSRBAR) is not in this cpu's memory space.
+ */
+
+ pciauto_setup_device(hose, dev, 0, hose->pci_mem,
hose->pci_prefetch, hose->pci_io);
+
#ifndef CONFIG_PCI_NOSCAN
printf (" Scanning PCI bus %02x\n", hose->current_busno);
hose->last_busno = pci_hose_scan_bus(hose,hose->current_busno);
--
1.5.3.rc5.18.ga85e4
next prev parent reply other threads:[~2007-08-21 4:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 8:03 [U-Boot-Users] [PATCH] Fix MPC8544DS PCIe3 scsi Ed Swarthout
2007-08-20 14:14 ` Kumar Gala
2007-08-20 14:44 ` Kumar Gala
2007-08-21 4:55 ` Ed Swarthout [this message]
2007-08-24 7:00 ` [U-Boot-Users] [PATCH] fsl_pci_init - Remove self PCSRBAR allocation Kumar Gala
2007-08-29 0:09 ` Wolfgang Denk
2007-08-29 0:07 ` [U-Boot-Users] [PATCH] Fix MPC8544DS PCIe3 scsi Wolfgang Denk
2007-08-29 2:02 ` Andy Fleming
2007-08-29 2:56 ` Ed Swarthout
2007-08-29 19:53 ` Kumar Gala
2007-08-30 7:26 ` [U-Boot-Users] [PATCH] Revert "Fix MPC8544DS PCIe3 scsi." Ed Swarthout
2007-08-30 7:33 ` Wolfgang Denk
2007-08-29 0:05 ` [U-Boot-Users] [PATCH] Fix MPC8544DS PCIe3 scsi Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2007-08-27 2:39 [U-Boot-Users] [PATCH] fsl_pci_init - Remove self PCSRBAR allocation Swarthout Edward L-SWARTHOU
2007-08-29 0:21 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11876721332262-git-send-email-ed.swarthout@hwdebug.com \
--to=ed.swarthout@hwdebug.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.