Re: [RFC][PATCH 8/9] pagemap: use page walker pte_hole() helper

[Dave Hansen <haveblue@us.ibm.com>]

On Tue, 2007-08-21 at 17:01 -0500, Matt Mackall wrote:
> > +	copy_to_user(pm->out, &pfn, out_len);
> 
> And I think we want to keep the put_user in the fast path.

OK, updated:

static int add_to_pagemap(unsigned long addr, unsigned long pfn,
                          struct pagemapread *pm)
{
        /*
         * Make sure there's room in the buffer for an
         * entire entry.  Otherwise, only copy part of
         * the pfn.
         */
        if (pm->count >= PM_ENTRY_BYTES)
                __put_user(pfn pm->out);
        else
                copy_to_user(pm->out, &pfn, pm->count);

        pm->pos += PM_ENTRY_BYTES;
        pm->count -= PM_ENTRY_BYTES;
        if (pm->count <= 0)
                return PAGEMAP_END_OF_BUFFER;
        return 0;
}

I'll patch-bomb you with the (small) updates I just made.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>