From: Rusty Russell <rusty@rustcorp.com.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: bug in virtio network driver?
Date: Wed, 22 Aug 2007 13:08:39 +1000 [thread overview]
Message-ID: <1187752119.6174.7.camel@localhost.localdomain> (raw)
In-Reply-To: <200708211706.29676.arnd@arndb.de>
On Tue, 2007-08-21 at 17:06 +0200, Arnd Bergmann wrote:
> On Tuesday 21 August 2007, Rusty Russell wrote:
> > > One solution would be to use the xmit_done interrupt. Unfortunately this would
> > > require additional locking as multiple interrupts can happen at two or more
> > > cpus. Do you have any better ideas?
> >
> > The only reason that we don't do it in skb_xmit_done() is because
> > kfree_skb() isn't supposed to be called from an interrupt. But there's
> > dev_kfree_skb_any() which can be used.
>
> That will simply trigger a softirq, right? If you need the softirq anyway,
> why not do all the tx handling in the poll() method like other drivers?
That would work, too. It seems a little non-obvious to me to trigger
poll when a packet has been transmitted, but if that's the Standard I'll
follow.
Cheers,
Rusty.
next prev parent reply other threads:[~2007-08-22 3:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 8:48 bug in virtio network driver? Christian Borntraeger
2007-08-21 9:09 ` Rusty Russell
[not found] ` <200708211048.33534.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-21 9:09 ` Rusty Russell
2007-08-21 15:06 ` Arnd Bergmann
2007-08-22 3:08 ` Rusty Russell [this message]
[not found] ` <1187687377.19435.176.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-08-21 16:02 ` Christian Borntraeger
[not found] ` <200708211802.04103.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-29 21:07 ` Rusty Russell
[not found] ` <1188421640.5531.141.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-08-30 11:28 ` Christian Borntraeger
2007-08-30 11:28 ` Christian Borntraeger
2007-08-29 21:07 ` Rusty Russell
2007-08-21 16:02 ` Christian Borntraeger
-- strict thread matches above, loose matches on Subject: below --
2007-08-21 8:48 Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187752119.6174.7.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=arnd@arndb.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.