From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390 appldata_base: Remove module_exit function and modular stuff
Date: Fri, 24 Aug 2007 09:37:55 +0200 [thread overview]
Message-ID: <1187941075.13076.1.camel@localhost> (raw)
In-Reply-To: <alpine.LFD.0.999.0708240419120.14807@enigma.security.iitk.ac.in>
On Fri, 2007-08-24 at 04:21 +0530, Satyam Sharma wrote:
> > I has been a module once for debugging purposes That the module_exit
> > function still exists is "historical". We can remove it since it is dead
> > code.
>
> Thanks, fair enough. Does this mean you're acking them -- I'd prefer both
> the patches to be applied separately. Rationale: we should still fix the
> appldata_exit() related oops _before_ removing it so that in future if
> this needs to be made modular for debugging purpose again, just the
> removal patch can be reverted, but the oops would still be fixed in the
> commit before it.
ACK, the patches are fine.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2007-08-24 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0708230706570.2049@enigma.security.iitk.ac.in >
2007-08-23 1:38 ` [PATCH] s390 appldata_base: Misc cpuinit annotations and bugfix Satyam Sharma
2007-08-23 2:21 ` [PATCH] s390 appldata_base: Remove module_exit function and modular stuff Satyam Sharma
2007-08-23 11:01 ` Martin Schwidefsky
2007-08-23 22:51 ` Satyam Sharma
2007-08-24 7:37 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187941075.13076.1.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.