From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-wireless@vger.kernel.org,
"John W.Linville" <linville@tuxdriver.com>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH V2] Add iwlwifi wireless drivers
Date: Tue, 28 Aug 2007 17:07:11 +0800 [thread overview]
Message-ID: <1188292031.13078.262.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1188291015.7837.67.camel@johannes.berg>
On Tue, 2007-08-28 at 10:50 +0200, Johannes Berg wrote:
> To be fair, that's not what you do, you're building two drivers from
> one source rather than have a single driver that supports both. I'm
> fairly certain Christoph wouldn't object to the latter.
Because of the difference of the two hardwares (for example, in
iwl-command.h, iwl_rxon_assoc_cmd differs between 3945 and 4965),
runtime supporting is difficult if not possible (hw structures differs).
So we select to do it statically by generating two drivers from one
source code.
Do you think if it is a good idea to split them into two drivers and
make each of them "#include iwl-base.c"? Please don't hesitate to share
if you have better ideas.
Thanks,
-yi
next prev parent reply other threads:[~2007-08-28 9:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 5:20 [PATCH V2] Add iwlwifi wireless drivers Zhu Yi
2007-08-27 13:10 ` Christoph Hellwig
2007-08-28 7:25 ` Zhu Yi
2007-08-28 8:50 ` Johannes Berg
2007-08-28 9:07 ` Zhu Yi [this message]
2007-08-28 9:28 ` Johannes Berg
2007-08-28 12:28 ` Christoph Hellwig
2007-08-28 13:37 ` Tomas Winkler
2007-08-31 20:55 ` John W. Linville
2007-08-31 22:03 ` Johannes Berg
2007-09-01 10:04 ` Johannes Berg
2007-09-04 2:25 ` Zhu Yi
2007-09-04 14:13 ` Johannes Berg
2007-09-06 1:32 ` Ian Schram
2007-09-06 2:20 ` Larry Finger
2007-09-06 12:00 ` Johannes Berg
2007-09-06 14:04 ` Tomas Winkler
2007-09-06 14:14 ` Johannes Berg
2007-09-06 14:31 ` Tomas Winkler
2007-09-06 14:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188292031.13078.262.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.