From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it) Date: Fri, 31 Aug 2007 14:13:29 -0500 Message-ID: <1188587609.10527.0.camel@squirrel> References: <59abf66e0708311119p2b83fcffg31fac1c298cfc10a@mail.gmail.com> <1188586457.8543.2.camel@squirrel> <59abf66e0708311205n6f6086d0g5d7c786ff2bef02b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Jorge =?ISO-8859-1?Q?Luc=E1ngeli?= Obes Return-path: In-Reply-To: <59abf66e0708311205n6f6086d0g5d7c786ff2bef02b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ck9uIEZyaSwgMjAwNy0wOC0zMSBhdCAxNjowNSAtMDMwMCwgSm9yZ2UgTHVjw6FuZ2VsaSBPYmVz IHdyb3RlOgo+IE9uIDgvMzEvMDcsIEFudGhvbnkgTGlndW9yaSA8YW50aG9ueUBjb2RlbW9ua2V5 LndzPiB3cm90ZToKPiA+IEl0IG1ha2VzIGxpdHRsZSBzZW5zZSB0byBwYXNzIGEgZGlyZWN0b3J5 IHdoZW4geW91IGNhbiBwYXNzIGEgY29uZmlnCj4gPiBmaWxlIGFuZCBhc3N1bWUgdGhhdCB0aGUg ZGlyZWN0b3J5IHRoZSBjb25maWcgZmlsZSBpcyBpbiBpcyB0aGUgQ1dELgo+ID4KPiA+IEZvciBp bnN0YW5jZSwgaWYgdm0uY2ZnIGNvbnRhaW5lZCBqdXN0IHRoZSBjb21tYW5kIGxpbmUgYXJndW1l bnRzLCB5b3UKPiA+IGNvdWxkIGhhdmU6Cj4gPgo+ID4gTXlJbWFnZS92bS5jZmc6ICAgICAgICAt aGRhIGRpc2swLnFjb3cgLW0gNTEyCj4gPiBNeUltYWdlL2Rpc2swLnFjb3c6ICAgIDxkaXNrIGlt YWdlPgo+ID4KPiA+IEFuZCB0aGVuIGRvOgo+ID4KPiA+IHFlbXUgLWMgTXlJbWFnZS92bS5jZmcK PiAKPiBJIHRob3VnaHQgYWJvdXQgdGhpcyB3aGVuIGNvZGluZywgYW5kIGl0J3MgdHJ1ZS4gTWF5 YmUgd2UgY291bGQganVzdAo+IGxlYXZlIGEgbmV3IGV4cGxpY2l0IGNvbmZpZyBmaWxlIG9wdGlv bi4gSSBpbnNpc3Qgb24gbWFraW5nIHRoaXMgYXMKPiBzaW1wbGUgYXMgcG9zc2libGUsIHRoYXQn cyB3aHkgSSAgY2hvc2UgdG8gdXNlIHRoZSBjb25maWcgZmlsZSBhcyBhCj4gIndyaXR0ZW4tZG93 biIgY29tbWFuZCBsaW5lLgo+IAo+IElmIHRoaXMgd2VyZSB0aGUgY2FzZSwgd2UgY291bGQgcmVt b3ZlIHRoZSByZXN0cmljdGlvbiBvZiBoYXZpbmcgdGhlCj4gY29uZmlnIGZpbGUgcmVmZXIgb25s eSB0byBpbWFnZXMgb24gdGhlIHNhbWUgZGlyZWN0b3J5LCBhcyB0aGUgdXNlIG9mCj4gdGhlIGNv bmZpZyBmaWxlIHdvdWxkIGJlIGV4cGxpY2l0LiBUaG91Z2h0cz8KClllcy4gIEl0IHNob3VsZCBi ZSBhIHZlcnkgc2ltcGxlIHBhdGNoLgoKUmVnYXJkcywKCkFudGhvbnkgTGlndW9yaQoKPiBDaGVl cnMsCj4gSm9yZ2UKCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tClRoaXMgU0YubmV0IGVtYWlsIGlzIHNwb25z b3JlZCBieTogU3BsdW5rIEluYy4KU3RpbGwgZ3JlcHBpbmcgdGhyb3VnaCBsb2cgZmlsZXMgdG8g ZmluZCBwcm9ibGVtcz8gIFN0b3AuCk5vdyBTZWFyY2ggbG9nIGV2ZW50cyBhbmQgY29uZmlndXJh dGlvbiBmaWxlcyB1c2luZyBBSkFYIGFuZCBhIGJyb3dzZXIuCkRvd25sb2FkIHlvdXIgRlJFRSBj b3B5IG9mIFNwbHVuayBub3cgPj4gIGh0dHA6Ly9nZXQuc3BsdW5rLmNvbS8KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtLWRldmVsIG1haWxpbmcgbGlz dAprdm0tZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9y Z2UubmV0L2xpc3RzL2xpc3RpbmZvL2t2bS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRBw2-0004PI-0w for qemu-devel@nongnu.org; Fri, 31 Aug 2007 15:13:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRBvz-0004P0-Oz for qemu-devel@nongnu.org; Fri, 31 Aug 2007 15:13:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRBvz-0004Ox-LM for qemu-devel@nongnu.org; Fri, 31 Aug 2007 15:13:35 -0400 Received: from wa-out-1112.google.com ([209.85.146.176]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IRBvz-0004L0-DR for qemu-devel@nongnu.org; Fri, 31 Aug 2007 15:13:35 -0400 Received: by wa-out-1112.google.com with SMTP id k22so1100791waf for ; Fri, 31 Aug 2007 12:13:34 -0700 (PDT) From: Anthony Liguori In-Reply-To: <59abf66e0708311205n6f6086d0g5d7c786ff2bef02b@mail.gmail.com> References: <59abf66e0708311119p2b83fcffg31fac1c298cfc10a@mail.gmail.com> <1188586457.8543.2.camel@squirrel> <59abf66e0708311205n6f6086d0g5d7c786ff2bef02b@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Date: Fri, 31 Aug 2007 14:13:29 -0500 Message-Id: <1188587609.10527.0.camel@squirrel> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] Re: [kvm-devel] [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jorge =?ISO-8859-1?Q?Luc=E1ngeli?= Obes Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org On Fri, 2007-08-31 at 16:05 -0300, Jorge Lucángeli Obes wrote: > On 8/31/07, Anthony Liguori wrote: > > It makes little sense to pass a directory when you can pass a config > > file and assume that the directory the config file is in is the CWD. > > > > For instance, if vm.cfg contained just the command line arguments, you > > could have: > > > > MyImage/vm.cfg: -hda disk0.qcow -m 512 > > MyImage/disk0.qcow: > > > > And then do: > > > > qemu -c MyImage/vm.cfg > > I thought about this when coding, and it's true. Maybe we could just > leave a new explicit config file option. I insist on making this as > simple as possible, that's why I chose to use the config file as a > "written-down" command line. > > If this were the case, we could remove the restriction of having the > config file refer only to images on the same directory, as the use of > the config file would be explicit. Thoughts? Yes. It should be a very simple patch. Regards, Anthony Liguori > Cheers, > Jorge