All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Mandeep Singh Baines <mandeep.baines@gmail.com>
Cc: Daniele Venzano <venza@brownhat.org>,
	davem@davemloft.net, rick.jones2@hp.com, msb@google.com,
	netdev@vger.kernel.org, grundler@google.com,
	robert.olsson@its.uu.se, jeff@garzik.org, nhorman@tuxdriver.com
Subject: Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition
Date: Tue, 04 Sep 2007 09:03:56 -0400	[thread overview]
Message-ID: <1188911036.4483.10.camel@localhost> (raw)
In-Reply-To: <20070904032036.GA11153@ludhiana>

On Mon, 2007-03-09 at 20:20 -0700, Mandeep Singh Baines wrote:

> I didn't see much saving in interrupts on my machine (too fast, I guess). 

You could try the idea suggested by Dave earlier and just turn interupts
for every nth packet. That should cut down the numbers.

> I did see a significant boost to tx performance by optimizing start_xmit: more
> than double pps in pktgen.

148Kpps on a slow piece of hardware aint bad - Good Stuff. I wonder how
much CPU is being abused.

If you wanna go one extra mile (separate future patch): get rid of that
tx lock and use netif_tx_lock on the interupt path. Look at some sane
driver like tg3 for reference.

cheers,
jamal


  reply	other threads:[~2007-09-04 13:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-01 10:47 pktgen terminating condition Daniele Venzano
2007-09-04  3:20 ` [PATCH] [sis900] convert to NAPI, WAS " Mandeep Singh Baines
2007-09-04 13:03   ` jamal [this message]
2007-09-04 17:21     ` Mandeep Baines
2007-09-04 16:56   ` Daniele Venzano
2007-09-04 17:24     ` Mandeep Baines
2007-09-05  7:44     ` Mandeep Singh Baines
2007-09-05 12:03       ` James Chapman
2007-09-05 12:33         ` jamal
2007-09-05 13:55           ` James Chapman
2007-09-05 14:21             ` jamal
2007-09-06  5:06               ` Mandeep Singh Baines
2007-09-06 13:22                 ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1188911036.4483.10.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=grundler@google.com \
    --cc=jeff@garzik.org \
    --cc=mandeep.baines@gmail.com \
    --cc=msb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=rick.jones2@hp.com \
    --cc=robert.olsson@its.uu.se \
    --cc=venza@brownhat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.