From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH] Improved support for different bt87x board configurations Date: Tue, 04 Sep 2007 14:54:39 +0100 Message-ID: <1188914079.6535.47.camel@areia> References: <1188801407.6762.1208578117@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by alsa0.perex.cz (Postfix) with ESMTP id 3D75E1037FD for ; Tue, 4 Sep 2007 15:54:22 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Trent Piepho Cc: Takashi Iwai , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org > Ok, that's what I did. The other checkpatch warnings are fixed too. > +/* Cards with configuration information */ > +enum snd_bt87x_boardid { > + SND_BT87X_BOARD_GENERIC, > + SND_BT87X_BOARD_ANALOG, /* board with no external A/D > */ > + SND_BT87X_BOARD_HAUPPAUGE878, > + SND_BT87X_BOARD_OSPREY2x0, > + SND_BT87X_BOARD_OSPREY440, > + SND_BT87X_BOARD_ATI_TVWONDER, > + SND_BT87X_BOARD_WINFAST2000, > + SND_BT87X_BOARD_VOODOOTV_200, > + SND_BT87X_BOARD_AVPHONE98, Hmm... Maybe it would be a good idea to move the board numbers from linux/drivers/media/video/bt8xx/bttv.h to a separate header (maybe something like /include/media/bt8xx-cards.h) and use the same board IDs for both -alsa and -v4l drivers. This will make easier to associate the audio and video parts for troubleshooting and newer developments. Cheers, Mauro.