From: "Anil Veerabhadrappa" <anilgv@broadcom.com>
To: Michael Chan <mchan@broadcom.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Mike Christie <mchristi@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org,
open-iscsi@googlegroups.com, Tal Moyal <talm@broadcom.com>,
Robert Lusinsky <lusinsky@broadcom.com>,
Uri Elzur <uri@broadcom.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.
Date: Sat, 08 Sep 2007 10:57:39 -0700 [thread overview]
Message-ID: <1189274259.12688.28.camel@localhost.localdomain> (raw)
In-Reply-To: <1551EAE59135BE47B544934E30FC4FC002AABA51@nt-irva-0751.brcm.ad.broadcom.com>
On Sat, 2007-09-08 at 07:49 -0700, Michael Chan wrote:
> Christoph Hellwig wrote:
>
> > Most of it should just go away, and the other bits shouldn't
> > change over
> > the lifetime of the driver except for additions. So there
> > really isn't
> > any point in auto-generating it.
> >
>
> Yes, I agree with Mike Christie on this. These values in
> question are defined in iSCSI RFC and therefore should be defined
> in a common file.
Sure, we will remove these duplicate defines from bnx2i header file and
work of iscsi_proto.h macro definitions
next prev parent reply other threads:[~2007-09-08 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1188599815.5176.12.camel@dell>
2007-09-05 18:34 ` [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices Mike Christie
2007-09-05 21:27 ` Anil Veerabhadrappa
2007-09-07 22:23 ` Mike Christie
2007-11-21 18:38 ` Anil Veerabhadrappa
2007-11-21 19:17 ` James Smart
[not found] ` <1195670296.8767.9.camel-opBMJL+S1+mb6IhXEaeG+wpgy58w7zIFpWgKQ6/u3Fg@public.gmane.org>
2007-11-27 4:15 ` Mike Christie
2007-11-28 0:44 ` Anil Veerabhadrappa
[not found] ` <1196210691.5980.20.camel-opBMJL+S1+mb6IhXEaeG+20Cxg0+/0ngpWgKQ6/u3Fg@public.gmane.org>
2007-11-28 20:06 ` Mike Christie
2007-11-29 0:36 ` Anil Veerabhadrappa
2007-09-08 11:59 ` Christoph Hellwig
2007-09-08 14:49 ` Michael Chan
2007-09-08 17:57 ` Anil Veerabhadrappa [this message]
[not found] <46F8C935.8050907@suse.de>
[not found] ` <20070925133624H.tomof@acm.org>
[not found] ` <46FB5C6B.3020506@garzik.org>
2007-09-27 8:06 ` FUJITA Tomonori
2007-09-27 8:23 ` Jeff Garzik
[not found] <46FB6087.10306@garzik.org>
[not found] ` <1190880779.6158.0.camel@pasglop>
[not found] ` <46FB6837.7040308@garzik.org>
2007-09-27 8:46 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189274259.12688.28.camel@localhost.localdomain \
--to=anilgv@broadcom.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lusinsky@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mchristi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=talm@broadcom.com \
--cc=uri@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.