From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: clockevents: fix resume logic
Date: Tue, 11 Sep 2007 08:37:16 +0200 [thread overview]
Message-ID: <1189492636.25767.62.camel@chaos> (raw)
In-Reply-To: <20070910144740.4eba2fda.akpm@linux-foundation.org>
On Mon, 2007-09-10 at 14:47 -0700, Andrew Morton wrote:
> >
> > clockevents: fix resume logic
> >
> > We need to make sure, that the clockevent devices are resumed, before
> > the tick is resumed. The current resume logic does not guarantee this.
> >
> > Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock
> > event devices before resuming the tick / oneshot functionality.
> >
> > Fixup the existing users.
> >
> > Thanks to Nigel Cunningham for tracking down a long standing thinko,
> > which affected the jinxed VAIO.
> >
>
> This patch broke the jinxed vaio.
>
> Which is a bit odd, considering that I must have tested it at the time.
> But I bisected it right down to this commit, and the below revert patch
> fixed it up.
I just looked up, that you confirmed earlier that the patch does _not_
break the VAIO.
I think, that some other suspend/resume/ACPI or whatever change went in
before this patch got merged into Linus tree. Sigh. That's pretty hard
to find out.
tglx
next prev parent reply other threads:[~2007-09-11 6:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200707220159.l6M1xBgH001236@hera.kernel.org>
2007-09-10 21:47 ` clockevents: fix resume logic Andrew Morton
2007-09-11 6:37 ` Thomas Gleixner [this message]
2007-09-11 7:00 ` Andrew Morton
2007-09-11 7:23 ` Thomas Gleixner
2007-09-11 7:34 ` Thomas Gleixner
2007-09-11 7:44 ` Andrew Morton
2007-09-11 7:47 ` Thomas Gleixner
2007-09-11 8:20 ` Andrew Morton
2007-09-11 8:35 ` Andrew Morton
2007-09-11 9:16 ` Thomas Gleixner
2007-09-11 10:31 ` Andrew Morton
2007-09-11 11:23 ` Rafael J. Wysocki
2007-09-11 11:22 ` Andrew Morton
2007-09-11 12:09 ` Rafael J. Wysocki
2007-09-11 18:25 ` Andrew Morton
2007-09-11 18:38 ` Thomas Gleixner
2007-09-11 18:44 ` Andrew Morton
2007-09-11 19:52 ` Thomas Gleixner
2007-09-11 21:49 ` Thomas Gleixner
2007-09-12 9:16 ` Andrew Morton
2007-09-12 16:57 ` Thomas Gleixner
2007-09-13 4:48 ` Andrew Morton
2007-09-12 9:12 ` Andrew Morton
2007-09-17 18:37 ` Pavel Machek
2007-09-22 8:50 ` Thomas Gleixner
2007-09-22 10:47 ` Rafael J. Wysocki
2007-10-02 8:05 ` Pavel Machek
2007-09-11 19:35 ` Rafael J. Wysocki
2007-09-11 19:39 ` Andrew Morton
2007-09-11 19:40 ` Arjan van de Ven
2007-09-11 9:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189492636.25767.62.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.