All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Anil K. Ravindranath" <anil_ravindranath@adaptec.com>
To: Linux-scsi@vger.kernel.org, James.Bottemley@SteelEye.com
Subject: Re: [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE Adaptec SCSI controller
Date: Thu, 20 Sep 2007 08:08:09 -0700	[thread overview]
Message-ID: <1190300889.31372.4.camel@linux.site> (raw)
In-Reply-To: <1183207551.14436.15.camel@linux.site>

Hi,

We have not heard any comments or inputs on this patch. 

With regards,
  Anil

On Sat, 2007-06-30 at 05:45 -0700, Anil K. Ravindranath wrote:
> Subject: [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE
> Adaptec SCSI controller
> 
> Contribution:
> 
> Anil Ravindranath <anil_ravindranath@adaptec.com>
> 
> Issue:
> 
> Data Bursts that cross from 32- to 64-Bit address space have incorrect
> address for 29320LPE. This leads to potential data corruption.
> 
> Fix:
> 
> Restrict DMA to 32bit so that it does not cross 4GB boundary.
> 
> Change Log:
> 
> Restrict DMA to 32bit for 29320LPE so that it does not cross 4GB
> boundary
> 
> Patch: apply to scsi-misc-2.6.git development tree
> 
> Signed off By:  Anil Ravindranath <anil_ravindranath@adaptec.com>
> 
> diff -urN a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c
> b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c
> --- a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c    2007-06-30
> 05:24:08.000000000 -0700
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c    2007-06-30
> 05:25:40.000000000 -0700
> @@ -161,7 +161,10 @@
>         }
>         pci_set_master(pdev);
> 
> -       if (sizeof(dma_addr_t) > 4) {
> +       /*
> +        * Restrict DMA to 32bit for 29320LPE
> +        */
> +       if ((sizeof(dma_addr_t) > 4) && (entry->full_id !=
> ID_AHA_29320LPE)) {
>                 const u64 required_mask = dma_get_required_mask(dev);
> 
>                 if (required_mask > DMA_39BIT_MASK &&
> 
> 
> 
> diffstat output:
> 
> aic79xx_osm_pci.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletion(-)
> 
> With regards,
>   Anil

  reply	other threads:[~2007-09-21  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-30 12:45 [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE Adaptec SCSI controller Anil K. Ravindranath
2007-09-20 15:08 ` Anil K. Ravindranath [this message]
2007-09-21  0:41   ` James Bottomley
     [not found]     ` <1190305223.1588.7.camel@linux.site>
2007-09-21 15:37       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190300889.31372.4.camel@linux.site \
    --to=anil_ravindranath@adaptec.com \
    --cc=James.Bottemley@SteelEye.com \
    --cc=Linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.