From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 3/6] virtio net driver Date: Sun, 23 Sep 2007 17:13:50 +1000 Message-ID: <1190531630.27805.106.camel@localhost.localdomain> References: <1190289808.7262.223.camel@localhost.localdomain> <200709211436.43964.borntraeger@de.ibm.com> <20070921140833.GA12242@gondor.apana.org.au> <200709211642.25208.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, lguest , Herbert Xu , Jeff Garzik , virtualization To: Christian Borntraeger Return-path: In-Reply-To: <200709211642.25208.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, 2007-09-21 at 16:42 +0200, Christian Borntraeger wrote: > Am Freitag, 21. September 2007 schrieb Herbert Xu: > > Please don't use LLTX in new drivers. We're trying to get rid > > of it since it's > > > > 1) unnecessary; > > 2) causes problems with AF_PACKET seeing things twice. > > Ok, but then I cannot reuse the xmit lock in an interrupt handler. Otherwise > deadlock can occur because hard_start_xmit has interrupts enabled. > > Rusty, seems we need an additional lock. Can we use a tasklet? Seems like it'd be safe at a glance... Thanks, Rusty. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/