From: Eric Paris <eparis@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: selinux@tycho.nsa.gov, sds@tycho.nsa.gov, ewalsh@tycho.nsa.gov,
sgrubb@redhat.com
Subject: Re: [PATCH -v4] kernel: selinux: policy selectable handling of unknown classes and perms
Date: Sun, 23 Sep 2007 19:02:41 -0400 [thread overview]
Message-ID: <1190588561.3451.165.camel@localhost.localdomain> (raw)
In-Reply-To: <Xine.LNX.4.64.0709231431320.23411@us.intercode.com.au>
On Sun, 2007-09-23 at 14:39 -0700, James Morris wrote:
> > +
> > + unsigned int reject_unknown : 1;
> > + unsigned int allow_unknown : 1;
> > + u32 *undefined_perms;
>
> Why two separate bitfields ?
You mean why did we split from a single "handle_unknown" to using 2
separate bits? See the message from Eamon
http://marc.info/?l=selinux&m=119033791127455&w=2
> > +int security_get_reject_unknown(void)
> > +int security_get_allow_unknown(void)
>
> Can you make these static inline?
These are used in selinuxfs.c and aren't we trying to let the compiler
make inline choices these days?
>
>
> What sort of testing has this had?
The patch (minus the bit field split) testing is explained in
http://marc.info/?l=selinux&m=118969604021576&w=2
After the bit field split I merely tested missing classes, I did not
retest all the scenarios described in the above message (namely i didn't
test missing perms alone), but the meat of the patch has not changed
since version 2.
-Eric
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2007-09-23 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 18:37 [PATCH -v4] kernel: selinux: policy selectable handling of unknown classes and perms Eric Paris
2007-09-21 20:15 ` Stephen Smalley
2007-09-23 23:15 ` James Morris
2007-09-23 21:39 ` James Morris
2007-09-23 23:02 ` Eric Paris [this message]
2007-09-23 23:08 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190588561.3451.165.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=ewalsh@tycho.nsa.gov \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.