From: Dave Hansen <haveblue@us.ibm.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: missing mnt_drop_write() on open error
Date: Tue, 25 Sep 2007 16:24:35 -0700 [thread overview]
Message-ID: <1190762675.26982.320.camel@localhost> (raw)
In-Reply-To: <E1IaJc0-000541-00@dorka.pomaz.szeredi.hu>
On Wed, 2007-09-26 at 01:14 +0200, Miklos Szeredi wrote:
> I get this at umount, if there was a failed open():
>
> WARNING: at fs/namespace.c:586 __mntput()
>
> I think the problem is that may_open() calls mnt_want_write(), but if
> open doesn't succeed, mnt_drop_write() will not be called.
I see what you're talking about, and it does look like a bug to me. I'm
working on establishing where the 'struct file' gets created in relation
to all of this, and where best we should back out the write count.
I should have a patch in a few.
-- Dave
next prev parent reply other threads:[~2007-09-25 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 23:14 missing mnt_drop_write() on open error Miklos Szeredi
2007-09-25 23:24 ` Dave Hansen [this message]
2007-09-26 1:21 ` Dave Hansen
2007-09-26 8:38 ` Miklos Szeredi
2007-09-26 15:07 ` Christoph Hellwig
2007-09-26 16:14 ` Dave Hansen
2007-09-26 16:19 ` Dave Hansen
2007-09-26 17:50 ` Miklos Szeredi
2007-09-26 18:08 ` Dave Hansen
2007-09-26 18:54 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190762675.26982.320.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.