From: Soeren Sonnenburg <kernel@nn7.de>
To: Thomas Rohwer <tr@tng.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Problem with appletouch driver in Linux version 2.6.23-rc7
Date: Wed, 26 Sep 2007 21:56:36 +0200 [thread overview]
Message-ID: <1190836596.1359.33.camel@localhost> (raw)
In-Reply-To: <46F7BA08.6000201@tng.de>
On Mon, 2007-09-24 at 15:22 +0200, Thomas Rohwer wrote:
> Hello,
>
> > could you please re-send the patch? I for some reason have yet to see
> > it ...
>
> here it is again, adressing also the comments from Dmitry.
Thomas, Matthew and Dmitry,
I think there is another bug in this. I mean whenever a mouse button is
pressed or the mouse is moved the counter should be reset - no?
Currently the idle counter is just increased...
I mean shouldn't it be
if (x || y || key)
dev->idlecount=0;
if (!x && !y && !key)
{
dev->idlecount++;
if (dev->idlecount == 10) {
dev->valid = 0;
schedule_work(&dev->work);
}
}
Soeren
next prev parent reply other threads:[~2007-09-26 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 17:14 Problem with appletouch driver in Linux version 2.6.23-rc7 Thomas Rohwer
2007-09-24 12:40 ` Dmitry Torokhov
2007-09-24 12:49 ` Matthew Garrett
2007-09-24 13:03 ` Soeren Sonnenburg
2007-09-24 13:22 ` Thomas Rohwer
2007-09-26 19:56 ` Soeren Sonnenburg [this message]
2007-09-26 20:13 ` Dmitry Torokhov
2007-09-27 17:51 ` Soeren Sonnenburg
2007-09-27 21:08 ` Thomas Rohwer
2007-10-13 21:33 ` Soeren Sonnenburg
2007-10-13 21:44 ` Matthew Garrett
2007-10-15 13:09 ` Dmitry Torokhov
2007-09-24 13:10 ` Thomas Rohwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190836596.1359.33.camel@localhost \
--to=kernel@nn7.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=mjg59@srcf.ucam.org \
--cc=tr@tng.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.