From: Thomas Gleixner <tglx@linutronix.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Molnar Ingo <mingo@elte.hu>,
benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] Compile handle_percpu_irq even for uniprocessor kernels
Date: Thu, 27 Sep 2007 13:28:59 +0200 [thread overview]
Message-ID: <1190892539.23376.90.camel@chaos> (raw)
In-Reply-To: <20070927112448.GA16909@linux-mips.org>
On Thu, 2007-09-27 at 12:24 +0100, Ralf Baechle wrote:
> Compiling handle_percpu_irq only on uniprocessor generates an artificial
> special case so a typical use like:
>
> set_irq_chip_and_handler(irq, &some_irq_type, handle_percpu_irq);
>
> needs to be conditionally compiled only on SMP systems as well and an
> alternative UP construct is usually needed - for no good reason.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Makes sense.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> This fixes uniprocessor configurations for some MIPS SMP systems.
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index f1a73f0..9b5dff6 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -503,7 +503,6 @@ out_unlock:
> spin_unlock(&desc->lock);
> }
>
> -#ifdef CONFIG_SMP
> /**
> * handle_percpu_IRQ - Per CPU local irq handler
> * @irq: the interrupt number
> @@ -529,8 +528,6 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
> desc->chip->eoi(irq);
> }
>
> -#endif /* CONFIG_SMP */
> -
> void
> __set_irq_handler(unsigned int irq, irq_flow_handler_t handle, int is_chained,
> const char *name)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2007-09-27 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 11:24 [PATCH] Compile handle_percpu_irq even for uniprocessor kernels Ralf Baechle
2007-09-27 11:28 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190892539.23376.90.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.