From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IawRF-0001by-VZ
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:42:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IawRC-0001Sx-4j
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:42:09 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IawRC-0001Sh-0I
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:42:06 -0400
Received: from honiara.magic.fr ([195.154.193.36])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1IawRB-00040O-Da
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:42:05 -0400
Subject: Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu...
From: Jocelyn Mayer <l_indien@magic.fr>
In-Reply-To: <1190908428.27143.7.camel@phantasm.home.enterpriseandprosperity.com>
References: <E1IatsM-0004DD-6T@cvs.savannah.gnu.org>
	<1190902080.29748.2.camel@jma4.dev.netgem.com>
	<1190908428.27143.7.camel@phantasm.home.enterpriseandprosperity.com>
Content-Type: text/plain
Date: Thu, 27 Sep 2007 18:41:51 +0200
Message-Id: <1190911311.29748.12.camel@jma4.dev.netgem.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: l_indien@magic.fr, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: thayne@c2.net, qemu-devel@nongnu.org

On Thu, 2007-09-27 at 09:53 -0600, Thayne Harbaugh wrote:
> On Thu, 2007-09-27 at 16:08 +0200, Jocelyn Mayer wrote:
> > On Thu, 2007-09-27 at 13:57 +0000, Thiemo Seufer wrote:
> > > CVSROOT:	/sources/qemu
> > > Module name:	qemu
> > > Changes by:	Thiemo Seufer <ths>	07/09/27 13:57:58
> > > 
> > > Modified files:
> > > 	linux-user     : qemu.h signal.c syscall.c 
> > > 	target-alpha   : cpu.h 
> > > 	target-arm     : cpu.h 
> > > 	target-i386    : cpu.h 
> > > 	target-mips    : cpu.h 
> > > 	target-ppc     : cpu.h 
> > 
> >  static inline target_ulong get_sp_from_cpustate(CPUPPCState *state)
> > {
> >   return state->gpr[1];
> > }
> > 
> > This is no way related to CPU emulation then has nothing to do in cpu.h.
> > Furthermore, there no notion of sigaltstack or even stack pointer in the
> > PowerPC specification.
> > Revert this patch immediatly, please, and stop breaking others code...
> 
> My apologies.  I put get_sp_from_cpustate() in cpu.h because it is a
> generic function that isn't exclusive to sigaltstack().  If it's
> preferred it can be exclusive to sigaltstack().
> 
> > How should we say "don't do weird things in others code" ??? Again, and
> > again and again...
> 
> My hope was that these types of comments would be made prior to the
> patch being committed.  Is there a developer document that describes the
> intentions of code layout, design philosophy, etc. so that I'm not
> guessing?

Then, I'm sorry, I did not notice this when you submitted your patch.
And I even did not imagine that it could touch anything out of
linux-user. Please apologize, I've been reading your submission too
fast, not being directly interressed by the patch...

> Please send me additional comments so that I can rework the patch for
> resubmission.

I don't know in which header you should define those ABI specific stuff.
Maybe a header may be added in the linux-user target subdirectories for
those kind of definitions; it may help avoiding too many #ifdef
everywhere...