From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757525AbXI2NwV (ORCPT ); Sat, 29 Sep 2007 09:52:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753075AbXI2NwN (ORCPT ); Sat, 29 Sep 2007 09:52:13 -0400 Received: from ozlabs.org ([203.10.76.45]:38879 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583AbXI2NwN (ORCPT ); Sat, 29 Sep 2007 09:52:13 -0400 Subject: Re: [PATCH] module: return error when mod_sysfs_init() failed From: Rusty Russell To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman In-Reply-To: <20070929100653.GA4121@APFDCB5C> References: <20070929100653.GA4121@APFDCB5C> Content-Type: text/plain Date: Sat, 29 Sep 2007 23:51:49 +1000 Message-Id: <1191073909.26950.40.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2007-09-29 at 19:06 +0900, Akinobu Mita wrote: > load_module() returns zero when mod_sysfs_init() fails, > then the module loading will succeed accidentally. > > This patch makes load_module() return error correctly in that case. Thanks, applied. Cheers, Rusty.