From: "Michael Chan" <mchan@broadcom.com>
To: "Andy Gospodarek" <andy@greyhouse.net>
Cc: "David Miller" <davem@davemloft.net>,
jeff@garzik.org, "netdev" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags
Date: Tue, 02 Oct 2007 15:02:56 -0700 [thread overview]
Message-ID: <1191362576.5961.15.camel@dell> (raw)
In-Reply-To: <20071002201634.GE9140@gospo.rdu.redhat.com>
On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote:
> Adding that flag in tg3_set_settings seemed like the most logical
> place
> since the driver works fine on boot. This is just an issue when
> re-enabling autonegotiation, so we should probably nip it there.
>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
We also noticed this issue recently, but didn't pay too much attention
to it since it was more of a "cosmetic" issue. The driver behaves the
same since we rely on cmd->autoneg to decide whether to enable autoneg
or not. Your fix seems reasonable to me. Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>
next prev parent reply other threads:[~2007-10-02 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 20:16 [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags Andy Gospodarek
2007-10-02 22:02 ` Michael Chan [this message]
2007-10-02 21:16 ` Andy Gospodarek
2007-10-08 8:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191362576.5961.15.camel@dell \
--to=mchan@broadcom.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.