All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Possible infinite loop in inotify code
Date: Thu, 04 Oct 2007 17:09:57 +0100	[thread overview]
Message-ID: <1191514197.3479.16.camel@cookie.hadess.net> (raw)
In-Reply-To: <1191513767.10698.148.camel@violet>

On Thu, 2007-10-04 at 18:02 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > Uli mentioned a possible infinite loop in some circumstances:
> > https://bugzilla.redhat.com/show_bug.cgi?id=235307
> > 
> > Although I wasn't able to reproduce the bug, the attached patch looks
> > technically correct.
> 
> I reworked the patch a little bit and applied it. The G_IO_STATUS_AGAIN
> and G_IO_ERROR_AGAIN are not guaranteed to be the same.

My mistake, I made the first patch using g_io_channel_read_chars instead
of the deprecated g_io_channel_read and changed the code accordingly
(including possible retvals), but then remembered eglib. I guess I
didn't completely revert those changes.

Cheers

-- 
Bastien Nocera <hadess@hadess.net> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2007-10-04 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-04 15:27 [Bluez-devel] Possible infinite loop in inotify code Bastien Nocera
2007-10-04 16:02 ` Marcel Holtmann
2007-10-04 16:09   ` Bastien Nocera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191514197.3479.16.camel@cookie.hadess.net \
    --to=hadess@hadess.net \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.