From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] gpio: Adds GPIO driver support for Armada100
Date: Tue, 19 Jul 2011 09:44:19 +0530 (IST) [thread overview]
Message-ID: <1191601059.27357.1311048859322.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <CALZhoSRFT3J5aP4m=504CpkbWdY60UJ0OVzjV9nMh--KcR=zKg@mail.gmail.com>
----- "Lei Wen" <adrian.wenl@gmail.com> wrote:
> Hi Ajay,
>
> On Tue, Jul 19, 2011 at 12:01 PM, Ajay Bhargav
> <ajay.bhargav@einfochips.com> wrote:
> >
> >> How about merge this into current mvmfp.c? Just add some function
> >> into
> >> it, then no need another c file.
> >>
> >> Best regards,
> >> Lei
> >>
> >
> > Hi Lei,
> >
> > According to current ongoing development there is generic GPIO
> framework being introduced. Its good if we keep gpio separate though
> they are connected to MFP too, It makes more sense if they are kept in
> different file. lets see what Prafulla has to say about this.
> >
> Ok.
> BTW, I also have some comments towards your patch.
> You define a huge structure in
> arch/arm/include/asm/arch-armada100/gpio.h, which don't looks so good
> to me.
>
Comments are welcome. I know its huge.. I just followed what is suggested by Wolfgang.
He told not to use BASE+OFFSET thing. I am bit confused here whom to follow :)
>
> Macro here save a lot space, and keep the code clean.
>
> Best regards,
> Lei
>
Prafulla is suggesting something.. Let me ask him how he want this.
Regards,
Ajay Bhargav
next prev parent reply other threads:[~2011-07-19 4:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 9:41 [U-Boot] [PATCH 1/4] gpio: Adds GPIO driver support for Armada100 Ajay Bhargav
2011-07-18 17:45 ` Mike Frysinger
2011-07-18 19:01 ` Prafulla Wadaskar
2011-07-19 4:04 ` Lei Wen
2011-07-19 4:01 ` Ajay Bhargav
2011-07-19 4:14 ` Lei Wen
2011-07-19 4:14 ` Ajay Bhargav [this message]
2011-07-20 3:49 ` Prafulla Wadaskar
2011-07-19 5:27 ` Wolfgang Denk
2011-07-19 5:55 ` Lei Wen
2011-07-19 4:23 ` Ajay Bhargav
2011-07-19 17:36 ` Prafulla Wadaskar
2011-07-20 7:11 ` Lei Wen
[not found] <550445252.29883.1311070783386.JavaMail.root@ahm.einfochips.com>
2011-07-19 10:29 ` Ajay Bhargav
2011-07-19 17:36 ` Prafulla Wadaskar
2011-07-20 7:13 ` Lei Wen
[not found] <814164661.33093.1311137863843.JavaMail.root@ahm.einfochips.com>
2011-07-20 5:36 ` Ajay Bhargav
2011-07-20 6:02 ` Wolfgang Denk
2011-07-20 6:36 ` Ajay Bhargav
2011-07-20 10:08 ` Lei Wen
2011-07-20 10:43 ` Ajay Bhargav
2011-07-20 12:18 ` Lei Wen
2011-07-20 12:20 ` Ajay Bhargav
2011-07-20 12:19 ` Wolfgang Denk
2011-07-20 12:09 ` Wolfgang Denk
[not found] <952685375.34177.1311145646630.JavaMail.root@ahm.einfochips.com>
2011-07-20 7:14 ` Ajay Bhargav
2011-07-20 7:28 ` Lei Wen
[not found] <1287709675.34262.1311146613076.JavaMail.root@ahm.einfochips.com>
2011-07-20 7:29 ` Ajay Bhargav
2011-07-20 7:48 ` Lei Wen
2011-07-20 7:54 ` Ajay Bhargav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191601059.27357.1311048859322.JavaMail.root@ahm.einfochips.com \
--to=ajay.bhargav@einfochips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.