Re: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create

[Thomas Monjalon <thomas@monjalon.net>]

07/02/2022 10:04, Akhil Goyal:
> > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst
> > b/doc/guides/prog_guide/cryptodev_lib.rst
> > index 62bd3577f5..8e16461dc6 100644
> > --- a/doc/guides/prog_guide/cryptodev_lib.rst
> > +++ b/doc/guides/prog_guide/cryptodev_lib.rst
> > @@ -1236,10 +1236,10 @@ crypto operations is similar except change to
> > respective op and xform setup).
> >       * Create asym crypto session and initialize it for the crypto device.
> >       * The session structure is hidden from the app, so void * is used.
> >       */
> > -    void *asym_session;
> > -    asym_session =
> > rte_cryptodev_asym_session_create(asym_session_pool,
> > +    void *asym_session = NULL;
> > +    ret = rte_cryptodev_asym_session_create(&asym_session,
> > asym_session_pool,
> >              cdev_id, &modex_xform);
> > -    if (asym_session == NULL)
> > +    if (ret < 0)
> >          rte_exit(EXIT_FAILURE, "Session could not be created\n");
> 
> Sample Code in the rst files is no more added. @Thomas: Could you please confirm?
> Probably a separate patch is required to clean this up.

Yes the target is to remove them.
Instead we want to include parts of examples with a specific syntax.
See literalinclude here:
https://doc.dpdk.org/guides/contributing/documentation.html#code-and-literal-block-sections