Re: [PATCH] Device tree bindings for Xilinx devices

[Josh Boyer <jwboyer@linux.vnet.ibm.com>]

On Mon, 2007-10-08 at 01:53 -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> This is a first draft, please review and comment.

I'll start off with the fact that I hardly consider myself a DT expert,
so take what I say with a grain of salt.

> On a side node, I think booting-without-of.txt could get really unwieldly
> in the near future.  Perhaps the device tree bindings should be organized
> differently and separated from the functional description of device tree
> usage.  Thoughts?
> 
> Cheers,
> g.
> 
>  Documentation/powerpc/booting-without-of.txt |   58 ++++++++++++++++++++++++++
>  1 files changed, 58 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
> index 20e0e6c..a6d6056 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1850,6 +1850,64 @@ platforms are moved over to use the flattened-device-tree model.
> 
>     More devices will be defined as this spec matures.
> 
> +   l) Xilinx ML300 Framebuffer
> +
> +   Simple framebuffer device from the ML300 reference design (also on the
> +   ML403 reference design as well as others).
> +
> +   Required properties:
> +    - compatible : Must include "xilinx,ml300-fb"

Similarly, "xilinx,ml403-fb" will be required for ML403 correct?  Or do
they share exact identical implementations?

> +    - reg : offset and length of the framebuffer register set
> +
> +   Optional properties:
> +    - resolution : <xres yres> pixel resolution of framebuffer.  Some
> +                   implementations use a different resolution.  Default
> +                   is <d#640 d#480>
> +    - virt-resolution : <xvirt yvirt> Size of framebuffer in memory.
> +                        Default is <d#1024 d#480>.
> +    - rotate-display : rotate display 180 degrees.
> +    - display-number : Logical number of display
> +
> +   m) Xilinx SystemACE
> +
> +   The Xilinx SystemACE device is used to program FPGAs from an FPGA
> +   bitstream stored on a CF card.  It can also be used as a generic CF
> +   interface device.
> +
> +   Required properties:
> +    - compatible : Must include "xilinx,sysace"
> +    - reg : offset and length of SystemACE register set
> +
> +   Recommended properties:
> +    - interrupt-parent, interrupts : Connection of device irq signal.
> +
> +   Optional properties:
> +    - number : logical number of the SystemACE device based at 0.

"number" seems a bit to generic to me.  logical-number seems a bit more
descriptive.

> +    - 8-bit (empty) : Set this property if the SystemACE must be in 8 bit mode
> +
> +   n) Xilinx EMAC and Xilinx TEMAC
> +
> +   Xilinx Ethernet devices.  Uses common properties from other Ethernet
> +   devices with the following constraints:
> +   
> +   Required properties:
> +    - compatible : Must include one of: "xilinx,plb-temac",
> +                   "xilinx,plb-emac", "xilinx-opb-emac"

I think you mean "xilinx,opb-emac" on that last one.

> +    - dma-mode : Must be one of "none", "simple", "sg" (sg == scatter gather)
> +
> +   o) Xilinx Uartlite
> +
> +   Xilinx uartlite devices are simple fixed speed serial ports.  Uartlite
> +   ports should be described in a node with the following properties.
> +
> +   Requred properties:
> +    - compatible : Must include "xilinx,uartlite"
> +    - reg : offset and length of uartlite register set
> +
> +    Recommended properties:
> +    - port-number : logical port number of uartlite device based at 0.
> +    - interrupt-parent, interrupts : Connection of device irq signal.
> +

josh