From: Johannes Berg <johannes@sipsolutions.net>
To: bruno randolf <bruno@thinktube.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: atheros hardware needs padding for QoS data
Date: Mon, 15 Oct 2007 10:47:16 +0200 [thread overview]
Message-ID: <1192438036.3349.16.camel@johannes.berg> (raw)
In-Reply-To: <200710151241.17651.bruno@thinktube.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Mon, 2007-10-15 at 12:41 +0900, bruno randolf wrote:
> but isn't doing a memmove() quite inefficient? especially since we are dealing
> with QoS packets that might be important.
It's only ~20 bytes that are moved, should be within one cache line and
we touch the packet data anyway. I don't think it's a problem.
> another solution i thought of was signalling the mac80211 layer that we need
> padding which could then just adjust it's headerlen. but then different
> drivers might need different padding in different places (i don't know?).
> what do you think of this approach?
That could be worthwhile, though the headerlen calculation is called
very very often and adding another branch into it could very well impact
performance worse than doing the memmove.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-10-15 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 10:46 atheros hardware needs padding for QoS data bruno randolf
2007-10-12 11:58 ` Johannes Berg
2007-10-12 13:09 ` Johannes Berg
2007-10-15 3:41 ` bruno randolf
2007-10-15 7:34 ` [PATCH] " bruno randolf
2007-10-15 8:31 ` Johannes Berg
2007-10-15 12:30 ` [PATCH] ath5k: atheros hardware needs header padding bruno randolf
2007-10-15 8:47 ` Johannes Berg [this message]
2007-10-15 9:00 ` atheros hardware needs padding for QoS data bruno randolf
2007-10-15 9:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192438036.3349.16.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=bruno@thinktube.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.