Re: [Qemu-devel] RFC: reverse-endian softmmu memory accessors

["J. Mayer" <l_indien@magic.fr>]

On Sun, 2007-10-14 at 14:22 +0100, Thiemo Seufer wrote:
> J. Mayer wrote:
> [snip]
> > > > Here's a new version. The only change is that, for consistency, I did
> > > > add the big-endian and little-endian accessors that were documented in
> > > > cpu-all.h as unimplemented. The implementation is quite trivial, having
> > > > native and reverse-endian accessors available, and changes functionnally
> > > > nothing to the previous version.
> > > 
> > > The patch does not apply anymore. The Sparc part looks OK.
> > > 
> > > The benefits from the patch can be gained by mapping Sparc64 lduw and
> > > ldsw in op_mem.h  directly to ldul and ldsl using SPARC_LD_OP and
> > > replacing the ldl+bswap etc. for the LE cases with ldlr in
> > > op_helper.c. If you prefer, I can do this after you have applied the
> > > patch.
> > 
> > Yes, there are conflicts between this patch and the mmu_idx one I just
> > commited. I will regenerate an updated diff in the hours to come, after
> > I finished commiting the PowerPC fixes and improvments I got waiting in
> > stock.
> > For the Sparc improvments, as I merged the PowerPC improvments in the
> > patch, I think it can be a good idea to include it directly in the
> > patch.
> > I'm also wondering if it would not be a good idea to define lduq/ldsq
> > even if they in fact do exactly what ldq does now, just to have a fully
> > consistent API.
> 
> Some architecture specs mention the possibility of 128 bit integers, so
> this sounds like a good idea.

OK, then I'll add this.
And I guess we can avoid the #if (TARGET_LONG_BITS == 64) for ldsl /
ldul changing the return type to target_ulong for those accessors.

-- 
J. Mayer <l_indien@magic.fr>
Never organized