From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, pexu@kapsi.fi,
Douglas Schilling Landgraf <dougsland@gmail.com>
Subject: Re: [build bug] error: 'VID_HARDWARE_GEMTEK' undeclared
Date: Mon, 15 Oct 2007 16:37:00 -0200 [thread overview]
Message-ID: <1192473420.5240.139.camel@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.58.0710151117260.15624@shell4.speakeasy.net>
Em Seg, 2007-10-15 às 11:27 -0700, Trent Piepho escreveu:
> On Mon, 15 Oct 2007, Ingo Molnar wrote:
> > randconfig testing of latest -git found this build bug:
> >
> > drivers/media/radio/radio-gemtek.c:557: error: 'VID_HARDWARE_GEMTEK' undeclared here (not in a function)
> >
> > config attached.
>
> Problem:
> # CONFIG_VIDEO_V4L1_COMPAT is not set
>
> The VID_HARDWARE_* defines are only created if that is turned on. gemtek
> should depend on VIDEO_V4L1_COMPAT.
>
> *or*
>
> As far as I can tell, these VID_HARDWARE defines are entirely useless. I
> couldn't find any instance of them being used for anything other than setting
> the .hardware field of struct video_device, and I was unable to find any
> instance of that field being used.
>
> It looks like the whole thing is just unused cruft. Mauro, would it be ok if
> I made a patch to just delete the whole mess?
Those VID_HARDWARE_* are bogus. No place checks for the .hardware value.
I've already made a patch removing it. Feel free to double check it.
--
Cheers,
Mauro
prev parent reply other threads:[~2007-10-15 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 11:13 [build bug] error: 'VID_HARDWARE_GEMTEK' undeclared Ingo Molnar
2007-10-15 13:16 ` [PATCH] radio-gemtek: fix " Pekka Seppänen
2007-10-15 13:49 ` Ingo Molnar
2007-10-15 15:11 ` [build bug] error: " Mauro Carvalho Chehab
2007-10-15 15:43 ` [patch] videbuf-core.c: fix build error Ingo Molnar
2007-10-15 18:27 ` [build bug] error: 'VID_HARDWARE_GEMTEK' undeclared Trent Piepho
2007-10-15 18:37 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192473420.5240.139.camel@gaivota \
--to=mchehab@infradead.org \
--cc=dougsland@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pexu@kapsi.fi \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.