From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: Problem building 3.1.1 HV for ia64
Date: Tue, 16 Oct 2007 11:16:53 -0600
Message-ID: <1192555013.13480.52.camel@bling>
References: <4714B20E.6060906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4714B20E.6060906@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Bill Burns <bburns@redhat.com>, Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir,

   I know 3.1.1 is done, but it would be great if you could add this
trivial patch to the tree.  If not, at least it's posted here for the
search engines to find.  Thanks,

	Alex

On Tue, 2007-10-16 at 08:43 -0400, Bill Burns wrote:
> I have run into an issue with the Xen 3.1.1 HV where it fails
> to build for ia64. I have worked up a patch that fixes the issue, but
> I wonder if maybe I am doing something wrong. It seems hard to believe that
> they 3.1.1 won't build ia64.
> 
> Anyway here is the issue. Building for common/domctl.c get an undefined
> reference error on guest_physmap_max_mem_pages. It is declared in arch
> dependent shadow.h files. Not sure why only the ia64 does not get the
> definition. But the following changeset removed the include of asm/shadow.h
> from common/domctl.c:
> 
> changeset:   15456:74b05c391535
> user:        Keir Fraser <keir@xensource.com>
> date:        Wed Oct 03 14:37:38 2007 +0100
> summary:     [XEN] replace shadow_* with paging_* in common code
> 

# HG changeset patch
# User Tim Deegan <Tim.Deegan@xensource.com>
# Date 1184937040 -3600
# Node ID 66db6b98f0720c08524754fc2364b126ef5cd2ab
# Parent  44e12d5b5178d007ae64abef9599d29edb05e5a3
Fix IA64 build
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
xen-unstable changeset: 66db6b98f072:66db6b98f0720c08524754fc2364b126ef5cd2ab
xen-unstable date: Fri Jul 20 14:10:40 2007 +0100

diff -r 44e12d5b5178 -r 66db6b98f072 xen/common/domctl.c
--- a/xen/common/domctl.c	Fri Jul 20 12:00:25 2007 +0100
+++ b/xen/common/domctl.c	Fri Jul 20 14:10:40 2007 +0100
@@ -20,6 +20,7 @@
 #include <xen/rcupdate.h>
 #include <xen/guest_access.h>
 #include <xen/bitmap.h>
+#include <xen/paging.h>
 #include <asm/current.h>
 #include <public/domctl.h>
 #include <acm/acm_hooks.h>